Bug 199077 - [patch] devel/pep8: make port concurrent
Summary: [patch] devel/pep8: make port concurrent
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sofian Brabez
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-31 21:05 UTC by rsmith
Modified: 2016-06-14 21:25 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sbz)


Attachments
Patch for devel/pep8 port Makefile (369 bytes, patch)
2015-03-31 21:05 UTC, rsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2015-03-31 21:05:59 UTC
Created attachment 155068 [details]
Patch for devel/pep8 port Makefile

A one-line change (see attached patch) to the port's Makefile makes this port concurrent.

Tested with Python 3.4;

Script started on Tue Mar 31 22:36:00 2015
root@slackbox:/usr/ports/devel/pep8 # diff -u Makefile.orig Makefile
--- Makefile.orig	2015-03-31 22:31:17.000000000 +0200
+++ Makefile	2015-03-31 22:31:48.000000000 +0200
@@ -13,7 +13,7 @@
 LICENSE=	MIT

 USES=		python
-USE_PYTHON=	distutils autoplist
+USE_PYTHON=	distutils autoplist concurrent py3kplist

 regression-test: extract
 	@(cd ${WRKSRC}; ${PYTHON_CMD} ${PORTNAME}.py \

root@slackbox:/usr/ports/devel/pep8 # portlint
looks fine.

root@slackbox:/usr/ports/devel/pep8 # env DEVELOPER=yes PYTHON_VERSION=python3.4 make stage
===>  License MIT accepted by the user
===>   py34-pep8-1.5.7 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by py34-pep8-1.5.7 for building
===>  Extracting for py34-pep8-1.5.7
=> SHA256 Checksum OK for pep8-1.5.7.tar.gz.
===>  Patching for py34-pep8-1.5.7
===>   py34-pep8-1.5.7 depends on package: py34-setuptools34>0 - found
===>   py34-pep8-1.5.7 depends on file: /usr/local/bin/python3.4 - found
===>  Configuring for py34-pep8-1.5.7
running config
===>  Building for py34-pep8-1.5.7
running build
running build_py
creating build
creating build/lib
copying pep8.py -> build/lib
running egg_info
writing pep8.egg-info/PKG-INFO
writing top-level names to pep8.egg-info/top_level.txt
writing namespace_packages to pep8.egg-info/namespace_packages.txt
writing entry points to pep8.egg-info/entry_points.txt
writing dependency_links to pep8.egg-info/dependency_links.txt
reading manifest file 'pep8.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.pyc' found under directory 'docs'
warning: no previously-included files matching '*.pyo' found under directory 'docs'
warning: no previously-included files matching '*.pyc' found under directory 'testsuite'
warning: no previously-included files matching '*.pyo' found under directory 'testsuite'
no previously-included directories found matching 'docs/_build'
writing manifest file 'pep8.egg-info/SOURCES.txt'
===>  Staging for py34-pep8-1.5.7
===>   py34-pep8-1.5.7 depends on package: py34-setuptools34>0 - found
===>   py34-pep8-1.5.7 depends on file: /usr/local/bin/python3.4 - found
===>   Generating temporary packing list
running install
running build
running build_py
running egg_info
writing entry points to pep8.egg-info/entry_points.txt
writing pep8.egg-info/PKG-INFO
writing namespace_packages to pep8.egg-info/namespace_packages.txt
writing top-level names to pep8.egg-info/top_level.txt
writing dependency_links to pep8.egg-info/dependency_links.txt
reading manifest file 'pep8.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.pyc' found under directory 'docs'
warning: no previously-included files matching '*.pyo' found under directory 'docs'
warning: no previously-included files matching '*.pyc' found under directory 'testsuite'
warning: no previously-included files matching '*.pyo' found under directory 'testsuite'
no previously-included directories found matching 'docs/_build'
writing manifest file 'pep8.egg-info/SOURCES.txt'
running install_lib
creating /usr/ports/devel/pep8/work/stage/usr/local/lib/python3.4
creating /usr/ports/devel/pep8/work/stage/usr/local/lib/python3.4/site-packages
copying build/lib/pep8.py -> /usr/ports/devel/pep8/work/stage/usr/local/lib/python3.4/site-packages
byte-compiling /usr/ports/devel/pep8/work/stage/usr/local/lib/python3.4/site-packages/pep8.py to pep8.cpython-34.pyc
writing byte-compilation script '/tmp/tmp6e6722g0.py'
/usr/local/bin/python3.4 -O /tmp/tmp6e6722g0.py
removing /tmp/tmp6e6722g0.py
running install_egg_info
Copying pep8.egg-info to /usr/ports/devel/pep8/work/stage/usr/local/lib/python3.4/site-packages/pep8-1.5.7-py3.4.egg-info
running install_scripts
Installing pep8 script to /usr/ports/devel/pep8/work/stage/usr/local/bin
writing list of installed files to '/usr/ports/devel/pep8/work/.PLIST.pymodtmp'
===> Moving suffixed files around
  bin/pep8 --> bin/pep8-3.4
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)

root@slackbox:/usr/ports/devel/pep8 # env DEVELOPER=yes PYTHON_VERSION=python3.4 make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

root@slackbox:/usr/ports/devel/pep8 # env DEVELOPER=yes PYTHON_VERSION=python3.4 make package
===>  Building package for py34-pep8-1.5.7

Script done on Tue Mar 31 22:44:26 2015
Comment 1 commit-hook freebsd_committer 2016-06-14 21:19:23 UTC
A commit references this bug:

Author: sbz
Date: Tue Jun 14 21:19:10 UTC 2016
New revision: 416911
URL: https://svnweb.freebsd.org/changeset/ports/416911

Log:
  - Allow Python concurrent installation
  - Use do-test target instead regression-test
  - Bump PORTREVISION

  PR:		199077
  Submitted by:	Roland Smith <rsmith at xs4all.nl>

Changes:
  head/devel/pep8/Makefile
  head/devel/pep8/distinfo
Comment 2 Sofian Brabez freebsd_committer 2016-06-14 21:25:04 UTC
Hi Roland,

Works like a charm.

% cd /usr/ports/devel/pep8
% sudo env DEVELOPER=yes PYTHON_VERSION=python2.7 make package
% sudo env DEVELOPER=yes PYTHON_VERSION=python3.5 make package
% ls *.txz
py27-pep8-1.7.0_1.txz   py35-pep8-1.7.0_1.txz

Committed into r416911. Thank you!