Bug 199220 - [PATCH] audio/quimup: Update to version 1.4.0
Summary: [PATCH] audio/quimup: Update to version 1.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-06 18:39 UTC by tkato432
Modified: 2015-10-10 12:16 UTC (History)
2 users (show)

See Also:


Attachments
audio_quimup.diff (2.26 KB, patch)
2015-04-06 18:39 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-04-06 18:39:34 UTC
Created attachment 155258 [details]
audio_quimup.diff
Comment 1 Alexey Dokuchaev freebsd_committer 2015-04-11 15:42:44 UTC
Your PR does not explain the switch from Qt4 to Qt5 at all.  Note that Qt4 is still being primarily used for vast majority of ports.  If needed, another quimup-qt5 port should be created instead (or quimup-qt4, if Qt5-version gains sufficient reasons to become default).
Comment 2 tkato432 2015-04-14 11:00:35 UTC
It appears that upstream author intentionally discontinued Qt4
support from the latest version.

Meanwhile, in general, keeping different versions of the same
applications featuring different toolkits as different ports
should be avoided unless upstream author claims that the latest
version hasn't been stable enough or each ports are necessary for
other ports as dependency.

In this case, it seem to me that it would be unnecessary to
preserve older version in ports tree due to retirement of Qt4
support.
Comment 3 commit-hook freebsd_committer 2015-10-10 12:16:21 UTC
A commit references this bug:

Author: marino
Date: Sat Oct 10 12:15:58 UTC 2015
New revision: 398991
URL: https://svnweb.freebsd.org/changeset/ports/398991

Log:
  audio/quimup: Upgrade version 1.3.2 => 1.4.0

  I tweaked provided patch to revert some unnecessary changes. Technically
  the change of ${PORTNAME} to quimup is unnecessary but I fully support
  the reversal of PORTNAME abuse.

  PR:		199220
  Submitted by:	ports fury

Changes:
  head/audio/quimup/Makefile
  head/audio/quimup/distinfo
Comment 4 John Marino freebsd_committer 2015-10-10 12:16:45 UTC
thanks