Created attachment 155546 [details]
Simple update to 4.2.1.
Poudriere log: http://uzsolt.hu/freebsd/poudriere/logs/amd64/adminer-4.2.1.log
Patched port fails to build like that:
Please, fix that and submit a new patch. Also, remember to run portlint over the port before submitting to get rid of all the errors and remember to use tabs instead of spaces in variable assignments.
Created attachment 155804 [details]
Poudriere log: http://uzsolt.hu/freebsd/poudriere/logs/amd64/adminer-4.2.1_1.log
I hope my latest patch is good. Or is there any other problem?
(In reply to Zsolt Udvari from comment #5)
Yes, the new patch is OK.
robak@, would you recheck it ?
The port looks almost fine, with few small issues:
* when PORTVERSION is increased, you should drop the PORTREVISION
* pay attention to using tabs instead of spaces in variables assignment
* always run portlint -ACNc and try to get rid of all possible errors/warnings (there are still few about your OPTIONS)
A commit references this bug:
Date: Tue Jul 28 08:21:35 UTC 2015
New revision: 393058
databases/adminer: update 4.1.0 -> 4.2.1
- Pet portlint
Submitted by: Zsolt Udvari <firstname.lastname@example.org> (maintainer)
Committed with minor changes, thanks!