Bug 199428 - [patch] ports-mgmt/portlint: make sure that first-paragraph things appear in the first paragraph
Summary: [patch] ports-mgmt/portlint: make sure that first-paragraph things appear in ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-13 20:56 UTC by Adam Weinberger
Modified: 2015-05-17 22:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
patch (607 bytes, patch)
2015-04-13 20:56 UTC, Adam Weinberger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2015-04-13 20:56:55 UTC 
Created attachment 155566 [details]
patch

The list of things from the first section (PORTNAME) that gets checked for order (checkorder()) contains things that aren't checked by checkearlier().

The consequence of this is that those items only get checked if they appear in the first section. If they appear elsewhere in the Makefile, portlint doesn't catch it.

Joe, I think that the list of items on line 2668 should be the same as the list on line 2307... do I have that right? If my logic is correct there, the attached patch makes those two lists identical.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2015-04-13 21:20:36 UTC 
Well, then, maybe the list should be put in a variable, so that duplication is not needed.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-05-11 15:31:57 UTC 
Committed to my CVS repo pending the next release.  Thanks!
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-05-17 22:46:13 UTC 
Committed, thanks!