Bug 199464 - port CATEGORIES check
Summary: port CATEGORIES check
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-15 11:51 UTC by Anton Yuzhaninov
Modified: 2015-04-15 15:52 UTC (History)
3 users (show)

See Also:


Attachments
patch for bsd.sanity.mk (673 bytes, text/plain)
2015-04-15 11:51 UTC, Anton Yuzhaninov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Yuzhaninov 2015-04-15 11:51:55 UTC
Created attachment 155622 [details]
patch for bsd.sanity.mk

in https://svnweb.freebsd.org/changeset/ports/383191
and https://svnweb.freebsd.org/changeset/ports/383665

Was added check for CATEGORIES to match directory in PORTSDIR.

This broke our setup with local ports outside PORTSDIR.

/usr/ports/vendor in our setup is symlink to VENDOR_DIR/ports/vendor directory.

Wile upgrading/installing our local ports warning message
"Not validating first entry in CATEGORIES due to being outside of PORTSDIR. Please ensure this is proper when committing."
displayed several times causing significant upgrade slowdown.

Please replace WARNING with DEV_WARNING. This message useful for ports developers/committers and rarely useful for end users.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-04-15 15:51:44 UTC
A commit references this bug:

Author: bdrewery
Date: Wed Apr 15 15:51:37 UTC 2015
New revision: 384059
URL: https://svnweb.freebsd.org/changeset/ports/384059

Log:
  The CATEGORY warning should be dev-only.

  PR:		199464
  Submitted by:	Anton Yuzhaninov <citrin+pr@citrin.ru>

Changes:
  head/Mk/bsd.sanity.mk
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2015-04-15 15:52:09 UTC
Thanks, committed.

This also improves your situation:

Author: bdrewery
Date: Wed Apr 15 15:49:01 2015
New Revision: 384058
URL: https://svnweb.freebsd.org/changeset/ports/384058

Log:
  Rework change from r383665 for CATEGORY validation so it does not show a
  warning when PORTSDIR is set to a directory that is symlinked to the real
  ports directory.
  
  Reported by:	smh
  With hat:	portmgr

Modified:
  head/Mk/bsd.sanity.mk