Bug 199503 - [PATCH] games/oolite: Convert to USES=gnustep
Summary: [PATCH] games/oolite: Convert to USES=gnustep
Status: Closed DUPLICATE of bug 200496
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-17 18:29 UTC by lightside
Modified: 2015-06-04 13:38 UTC (History)
3 users (show)

See Also:
avg: maintainer-feedback+


Attachments
Proposed patch (since 383856 revision) (2.30 KB, patch)
2015-04-17 18:29 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (48.29 KB, application/x-bzip2)
2015-04-17 21:45 UTC, lightside
no flags Details
Proposed patch (second variant, since 383856 revision) (1.12 KB, patch)
2015-05-02 21:52 UTC, lightside
no flags Details | Diff
Proposed patch for files directory (since 383856 revision) (18.91 KB, patch)
2015-05-02 21:53 UTC, lightside
no flags Details | Diff
The poudriere testport log for second variant (FreeBSD 10 amd64) (48.65 KB, application/x-bzip2)
2015-05-02 21:54 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2015-04-17 18:29:02 UTC
Created attachment 155679 [details]
Proposed patch (since 383856 revision)

Patch for games/oolite port and related files to convert it to USES=gnustep.

The games/oolite port was marked broken in ports r383856, after deletion of Mk/bsd.gnustep.mk file in ports r383626 and removing it from Mk/bsd.port.mk in ports r383627.

Looks like, the conversion from Mk/bsd.gnustep.mk to Mk/Uses/gnustep.mk file is not complete.
For example, the the games/oolite port uses USE_MAKEFILE define, which do not override MAKEFILE variable (Makefile by default). Also, it uses GNUSTEP_LOCAL_APPS define.
Comment 1 lightside 2015-04-17 18:33:11 UTC
The proposed patch modifies Mk/Uses/gnustep.mk file. There is a need to review it by port's manager.
Comment 2 lightside 2015-04-17 21:45:17 UTC
Created attachment 155683 [details]
The poudriere testport log (FreeBSD 10 amd64)

I attached the poudriere testport log (archive), based on applied proposed patch for FreeBSD ports Git repository in development branch.
Comment 3 lightside 2015-05-02 21:52:28 UTC
Created attachment 156254 [details]
Proposed patch (second variant, since 383856 revision)

In my opinion, the issue with new Mk/Uses/gnustep.mk file is related to regression category, because of:
- Removal of some defines used by ports, e.g. GNUSTEP_LOCAL_APPS in this case
- Overriding of MAKEFILE variable to different value, without possibility to change it, e.g. with USE_MAKEFILE define in this case

I don't know, whether this will be fixed or not.

Nevertheless, there is a workaround on games/oolite port level:
- Add correct GNUSTEP_LOCAL_APPS define
- Override DO_MAKE_BUILD variable, which used on do-build stage, e.g. use (default) Makefile instead of ${MAKEFILE} define

I attached the second variant of the proposed patch. It doesn't require approval from ports manager, I guess.

To Andriy Gapon (avg@, maintainer):
What do you think, which variant of the proposed patch should be used for commit?
Comment 4 lightside 2015-05-02 21:53:17 UTC
Created attachment 156255 [details]
Proposed patch for files directory (since 383856 revision)

Also, I attached the patch, which adapts patches in files directory, after ports r383894 changes for ports-mgmt/portlint v2.16.3.
Comment 5 lightside 2015-05-02 21:54:36 UTC
Created attachment 156256 [details]
The poudriere testport log for second variant (FreeBSD 10 amd64)
Comment 6 lightside 2015-05-28 17:26:12 UTC
The new 1.82 version was released:
http://aegidian.org/bb/viewtopic.php?f=1&t=17481
https://github.com/OoliteProject/oolite/releases/tag/1.82

I created new PR in bug 200496. Currently, it uses approach on the games/oolite port level.
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2015-06-04 13:38:47 UTC
Superseded by bug 200496.

*** This bug has been marked as a duplicate of bug 200496 ***