Bug 199544 - editors/abiword: dependency on converters/psiconv should be conditional but isn't
Summary: editors/abiword: dependency on converters/psiconv should be conditional but i...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on: 199156
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-19 16:28 UTC by Arthur Chance
Modified: 2015-06-18 22:24 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Chance 2015-04-19 16:28:20 UTC
The dependency on converters/psiconv is conditionalised on the PSION option at lines 120-126 of the Makefile, but is also included in the LIB_DEPENDS at the top at line 22, so is always required.

Fix by simply deleting the unconditional line.
Comment 1 Ben Woods freebsd_committer 2015-04-19 22:48:26 UTC
This issue is now fixed in the patch attached to PR199156.
Comment 2 commit-hook freebsd_committer 2015-06-18 22:20:44 UTC
A commit references this bug:

Author: truckman
Date: Thu Jun 18 22:20:28 UTC 2015
New revision: 390083
URL: https://svnweb.freebsd.org/changeset/ports/390083

Log:
  Update to 3.0.1, see <http://abisource.org/release-notes/3.0.1.phtml>.

  Add new Abiword collaboration backends for Telepathy and SIP as options.

  Fix improper handling of COLLAB options group.

  Get rid of improper unconditional dependency on converters/psiconv.

  Fix build with gcc.

  Portlint cleanup.

  PR:		199156
  PR:		195452
  PR:		199544
  PR:		193318
  Submitted by:	Ben Woods <woodsb02@gmail.com>
  Approved by:	mat (mentor, implicit)

Changes:
  head/editors/abiword/Makefile
  head/editors/abiword/distinfo
  head/editors/abiword/files/patch-Makefile.in
  head/editors/abiword/files/patch-plugins_bmp_xp_ie_impGraphic_BMP.cpp
  head/editors/abiword/files/patch-plugins_collab_backends_sipsimple_xp_SIPSimpleBuddy.h
  head/editors/abiword/files/patch-plugins_garble_xp_abiword-garble-png.cpp
  head/editors/abiword/files/patch-src_af_util_xp_ut_png.cpp
  head/editors/abiword/files/patch-src_text_ptbl_xp_pd__DocumentRDF.cpp
  head/editors/abiword/files/patch-src_text_ptbl_xp_pd__DocumentRDF.h
  head/editors/abiword/files/patch-src_wp_impexp_gtk_ie_impGraphic_GdkPixbuf.cpp
  head/editors/abiword/files/patch-tls_tunnel.cpp
  head/editors/abiword/pkg-plist