Bug 199558 - [PATCH] Add support for 24-bit and 32-bit resolution to audio/jack
Summary: [PATCH] Add support for 24-bit and 32-bit resolution to audio/jack
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-20 11:11 UTC by Hans Petter Selasky
Modified: 2015-06-14 15:07 UTC (History)
3 users (show)

See Also:


Attachments
Patch for jack port (5.75 KB, patch)
2015-04-20 11:11 UTC, Hans Petter Selasky
no flags Details | Diff
Copy of patch (5.62 KB, text/x-c)
2015-04-20 11:12 UTC, Hans Petter Selasky
no flags Details
Copy of patch .orig version (1.38 KB, patch)
2015-04-20 11:12 UTC, Hans Petter Selasky
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer 2015-04-20 11:11:34 UTC
Created attachment 155765 [details]
Patch for jack port

The JACK software use some hardcoded OSS constants from Linux, which don't work under FreeBSD. The attached patches adds support for 24-bit and 32-bit sample resolution under FreeBSD.

--HPS
Comment 1 Hans Petter Selasky freebsd_committer 2015-04-20 11:12:08 UTC
Created attachment 155766 [details]
Copy of patch
Comment 2 Hans Petter Selasky freebsd_committer 2015-04-20 11:12:26 UTC
Created attachment 155767 [details]
Copy of patch .orig version
Comment 3 Thomas Zander freebsd_committer 2015-06-14 11:20:07 UTC
There are three patch files attached to this PR. Would it be possible to reduce it to a single one versus recent -head? :-)
Comment 4 Hans Petter Selasky freebsd_committer 2015-06-14 12:00:25 UTC
Hi,

Doesn't the first patch apply to ports?

The others are just there to make the patch.

--HPS
Comment 5 commit-hook freebsd_committer 2015-06-14 15:06:07 UTC
A commit references this bug:

Author: riggs
Date: Sun Jun 14 15:05:12 UTC 2015
New revision: 389640
URL: https://svnweb.freebsd.org/changeset/ports/389640

Log:
  Fix support for 24-bit and 32-bit resolution

  While on it:
  - Pet portlint

  PR:		199558
  Submitted by:	hselasky@FreeBSD.org

Changes:
  head/audio/jack/Makefile
  head/audio/jack/files/patch-configure
  head/audio/jack/files/patch-drivers-alsa_memops.c
  head/audio/jack/files/patch-drivers-dummy-dummy_driver.c
  head/audio/jack/files/patch-drivers-dummy-dummy_driver.h
  head/audio/jack/files/patch-drivers-oss-oss_driver.c
  head/audio/jack/files/patch-drivers_alsa_memops.c
  head/audio/jack/files/patch-jack.pc.in
  head/audio/jack/files/patch-jackd_engine.c
  head/audio/jack/files/patch-libjack-client.c
Comment 6 Thomas Zander freebsd_committer 2015-06-14 15:07:16 UTC
Could you submit this patch upstream? Thanks!