Bug 199613 - [MAINTAINER] games/wtf: Update to 20150421
Summary: [MAINTAINER] games/wtf: Update to 20150421
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Adam Weinberger
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-04-22 14:29 UTC by Nikolai Lifanov
Modified: 2015-04-24 20:38 UTC (History)
1 user (show)

See Also:

Attachments
games/wtf 20150416 -> 20150421 (1.64 KB, patch)
2015-04-22 14:29 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
poudriere testport log (10.11 KB, text/plain)
2015-04-22 14:30 UTC, Nikolai Lifanov 		no flags Details
games/wtf 20150416 -> 20150422 (1.64 KB, patch)
2015-04-22 15:21 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
games/wtf 20150416 -> 20150422 (1.75 KB, patch)
2015-04-22 18:32 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
games/wtf 20150416 -> 20150424 (1.75 KB, patch)
2015-04-24 12:53 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
poudriere testport log (10.06 KB, text/plain)
2015-04-24 12:54 UTC, Nikolai Lifanov 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolai Lifanov 2015-04-22 14:29:44 UTC 
Created attachment 155858 [details]
games/wtf 20150416 -> 20150421

This update chases the upstream NetBSD split of acronyms database into offensive and non-offensive versions. The wtf utility gets a "-o" flag, which is now necessary for invocations like:

$ wtf wtf
wtf: I don't know what `wtf' means!
$ wtf -o wtf
....output....

The port received an option to install the offensive acronym database, selected by default, and installs a "fake" (empty) offensive acronym database if the option is deselected.
Comment 1 Nikolai Lifanov 2015-04-22 14:30:14 UTC 
Created attachment 155859 [details]
poudriere testport log

Please receive Poudriere testport log.
Comment 2 Nikolai Lifanov 2015-04-22 15:21:25 UTC 
Created attachment 155863 [details]
games/wtf 20150416 -> 20150422

Bump snapshot by a day. This one contains a doc fix:
 PR/49850: Nikolai Lifanov: Document acronyms-o
Comment 3 Nikolai Lifanov 2015-04-22 18:32:18 UTC 
Created attachment 155873 [details]
games/wtf 20150416 -> 20150422

I forgot to include bsd.port.options.mk in last patch.
Comment 4 Nikolai Lifanov 2015-04-24 12:53:28 UTC 
Created attachment 155943 [details]
games/wtf 20150416 -> 20150424

Update the patch to the latest snapshot.
Comment 5 Nikolai Lifanov 2015-04-24 12:54:11 UTC 
Created attachment 155944 [details]
poudriere testport log

Re-run poudriere testport the log with the latest patch.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-04-24 13:03:42 UTC 
I'm not sure OFFENSIVE should be an OPTIONS_DEFAULT (not a personal opinion). You are the maintainer, please consider the implications and advise.
Comment 7 Nikolai Lifanov 2015-04-24 13:08:42 UTC 
My reasoning is, all historic versions of this port had offensive acronyms included in the main acronyms database already and in the new version the user is shielded from them with the new "-o" flag. Also, upstream includes them by default. But it's nice to give people the OPTION to turn this off now that there is a mechanism for doing so.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-04-24 13:12:18 UTC 
Thanks for the feedback Nikolai
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-04-24 20:38:01 UTC 
A commit references this bug:

Author: adamw
Date: Fri Apr 24 20:37:57 UTC 2015
New revision: 384685
URL: https://svnweb.freebsd.org/changeset/ports/384685

Log:
  Update to 20150424.

  Introduce an OPTION that controls whether to install offensive (explicit)
  acronyms. It is enabled by default, but the actual wtf(6) app will not
  provide offensive answers without the -o switch.

  PR:		199613
  Submitted by:	maintainer (Nikolai Lifanov)

Changes:
  head/games/wtf/Makefile
  head/games/wtf/distinfo
  head/games/wtf/pkg-plist
Comment 10 Adam Weinberger freebsd_committer freebsd_triage 2015-04-24 20:38:38 UTC 
Nikolai, I agree with your logic here. Committing as submitted (with a spacing fix).