Bug 199805 - [maintainer] [patch] deskutils/cairo-dock deskutils/cairo-dock-plugins update to 3.4.1
Summary: [maintainer] [patch] deskutils/cairo-dock deskutils/cairo-dock-plugins update...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-30 11:15 UTC by Ivan Klymenko
Modified: 2015-05-09 09:58 UTC (History)
1 user (show)

See Also:


Attachments
patch-cairo-dock (2.18 KB, text/plain)
2015-04-30 11:15 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (1.90 KB, text/plain)
2015-04-30 11:16 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock (2.18 KB, text/plain)
2015-05-03 17:39 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (2.14 KB, text/plain)
2015-05-03 17:39 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock (2.23 KB, text/plain)
2015-05-07 11:01 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (2.45 KB, text/plain)
2015-05-07 11:02 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock (2.22 KB, text/plain)
2015-05-08 09:07 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (2.16 KB, text/plain)
2015-05-08 09:08 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock (1.98 KB, text/plain)
2015-05-09 07:15 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (1.89 KB, text/plain)
2015-05-09 07:15 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock (1.92 KB, text/plain)
2015-05-09 09:01 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (1.75 KB, text/plain)
2015-05-09 09:01 UTC, Ivan Klymenko
no flags Details
patch-cairo-dock-plugins (1.75 KB, text/plain)
2015-05-09 09:45 UTC, Ivan Klymenko
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Klymenko 2015-04-30 11:15:50 UTC
Created attachment 156142 [details]
patch-cairo-dock
Comment 1 Ivan Klymenko 2015-04-30 11:16:20 UTC
Created attachment 156143 [details]
patch-cairo-dock-plugins
Comment 2 Ivan Klymenko 2015-04-30 11:21:35 UTC
:/usr/ports/deskutils/cairo-dock # portlint -abt
looks fine.

:/usr/ports/deskutils/cairo-dock # make check-plist
...
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

:/usr/ports/deskutils/cairo-dock # make stage-qa
====> Running Q/A tests (stage-qa)


:/usr/ports/deskutils/cairo-dock-plugins # portlint -abt
looks fine.

:/usr/ports/deskutils/cairo-dock-plugins # make check-plist
...
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)


:/usr/ports/deskutils/cairo-dock-plugins # make stage-qa
====> Running Q/A tests (stage-qa)
Comment 3 Ivan Klymenko 2015-05-03 17:39:03 UTC
Created attachment 156300 [details]
patch-cairo-dock
Comment 4 Ivan Klymenko 2015-05-03 17:39:22 UTC
Created attachment 156302 [details]
patch-cairo-dock-plugins
Comment 5 Ivan Klymenko 2015-05-07 11:01:54 UTC
Created attachment 156465 [details]
patch-cairo-dock

Update pathes after commit https://svnweb.freebsd.org/ports?view=revision&revision=385521
Comment 6 Ivan Klymenko 2015-05-07 11:02:15 UTC
Created attachment 156466 [details]
patch-cairo-dock-plugins
Comment 7 Dmitry Marakasov freebsd_committer 2015-05-07 17:36:42 UTC
- why do you specify commit hash? You may omit GH_TAGNAME to use tags.
- cairo-dock-plugins fetch is broken: you fetch both distfiles from the same reposiory
- you may strip libgldi.so directly to not change this line on each update
- is there any real reason in overriding DISTNAMEs?
Comment 8 Ivan Klymenko 2015-05-07 17:54:54 UTC
(In reply to Dmitry Marakasov from comment #7)

I translated all of its ports to a common variant to avoid unnecessary words in the names of the archives distinfo.

https://svnweb.freebsd.org/ports/head/net-im/uTox/

In my opinion there is no need to see the names of files in a strange manner (vasia-pupkin-cairo-dock-pluginsXXXXX) and wonder - and what is in this archive?


Some committers make changes in my ports and others ask me why I did exactly the same in the new update.
Comment 9 Dmitry Marakasov freebsd_committer 2015-05-07 18:09:49 UTC
We have a common scheme for github-using ports, and cairo-dock* fall well under it. Distnames are named so on a purpose. Please stick to the standard scheme.
Comment 10 Ivan Klymenko 2015-05-08 09:07:47 UTC
Created attachment 156501 [details]
patch-cairo-dock
Comment 11 Ivan Klymenko 2015-05-08 09:08:01 UTC
Created attachment 156502 [details]
patch-cairo-dock-plugins
Comment 12 Ivan Klymenko 2015-05-08 09:25:24 UTC
(In reply to Dmitry Marakasov from comment #7)
>- cairo-dock-plugins fetch is broken: you fetch both distfiles from the same reposiory

is commit broken fetch https://svnweb.freebsd.org/ports/head/deskutils/cairo-dock-plugins/distinfo?r1=375699&r2=385521

---SHA256 (cairo-dock-plugins-png-icons.tar.gz) = f88327b073ac3673ea8765c608c7fe7beb1357b2c16c4dd8a26c14ec9cc2244a
+++SHA256 (cairo-dock-plugins-png-icons.tar.gz) = 5e841844f5cb99273b63f181b97acb0f1263aa6ba68bfe5afc6bf78675dbe505

---SIZE (cairo-dock-plugins-png-icons.tar.gz) = 1446489
+++SIZE (cairo-dock-plugins-png-icons.tar.gz) = 7398210

because original size archive pkg icons 1446489 for several years!
Comment 13 Ivan Klymenko 2015-05-09 07:15:36 UTC
Created attachment 156533 [details]
patch-cairo-dock
Comment 14 Ivan Klymenko 2015-05-09 07:15:52 UTC
Created attachment 156534 [details]
patch-cairo-dock-plugins
Comment 15 Ivan Klymenko 2015-05-09 07:17:19 UTC
Update patches after commit
https://svnweb.freebsd.org/changeset/ports/385842
Comment 16 Dmitry Marakasov freebsd_committer 2015-05-09 08:41:57 UTC
You're going to break fetch again by removing :icons from icons distfile.

Also as I've suggested before, please remove needless date addendum in PORTVERSION and GH_TAGNAME to follow upstream versioning and simplify makefile.
Comment 17 Ivan Klymenko 2015-05-09 09:01:32 UTC
Created attachment 156549 [details]
patch-cairo-dock
Comment 18 Ivan Klymenko 2015-05-09 09:01:48 UTC
Created attachment 156550 [details]
patch-cairo-dock-plugins
Comment 19 Ivan Klymenko 2015-05-09 09:45:26 UTC
Created attachment 156551 [details]
patch-cairo-dock-plugins
Comment 20 commit-hook freebsd_committer 2015-05-09 09:58:58 UTC
A commit references this bug:

Author: amdmi3
Date: Sat May  9 09:58:06 UTC 2015
New revision: 385877
URL: https://svnweb.freebsd.org/changeset/ports/385877

Log:
  - Update to 3.4.1
  - Follow upstream versioning
  - Simplify ports

  PR:		199805
  Submitted by:	fidaj@ukr.net (maintainer)

Changes:
  head/deskutils/cairo-dock/Makefile
  head/deskutils/cairo-dock/distinfo
  head/deskutils/cairo-dock/pkg-plist
  head/deskutils/cairo-dock-plugins/Makefile
  head/deskutils/cairo-dock-plugins/distinfo