Bug 199866 - [MAINTAINER-UPDATE] dns/knot: update on 1.6.3 - LibreSSL and GOST
Summary: [MAINTAINER-UPDATE] dns/knot: update on 1.6.3 - LibreSSL and GOST
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-02 18:22 UTC by Leo Vandewoestijne
Modified: 2015-05-18 11:22 UTC (History)
1 user (show)

See Also:


Attachments
update patch - with GOST enabled (3.46 KB, patch)
2015-05-02 18:22 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff
portlint -AC output (249 bytes, text/plain)
2015-05-02 18:23 UTC, Leo Vandewoestijne
no flags Details
poudriere 9.3 (185.32 KB, text/plain)
2015-05-02 18:40 UTC, Leo Vandewoestijne
no flags Details
poudriere log for 10.1 (197.68 KB, text/plain)
2015-05-02 18:40 UTC, Leo Vandewoestijne
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2015-05-02 18:22:32 UTC
Created attachment 156241 [details]
update patch - with GOST enabled

The upstream came with a different temporarily solution than the patch in PR 199298.
This one allows for GOST in DNSSEC.
I've tested it and it works fine.

Further Knot2 has been published. It will coexist for an unknown while.
It's changed a lot. And I have the port ready.
Now Knot 2.0.0-beta isn't ready to replace knot 1.6 yet, but at one point it will.
Is it smart to add the PKGNAMESUFFIX=16 ..?
Comment 1 Leo Vandewoestijne 2015-05-02 18:23:49 UTC
Created attachment 156242 [details]
portlint -AC output
Comment 2 Leo Vandewoestijne 2015-05-02 18:40:12 UTC
Created attachment 156243 [details]
poudriere 9.3
Comment 3 Leo Vandewoestijne 2015-05-02 18:40:42 UTC
Created attachment 156244 [details]
poudriere log for 10.1
Comment 4 Erwin Lansing freebsd_committer 2015-05-18 09:59:44 UTC
> Now Knot 2.0.0-beta isn't ready to replace knot 1.6 yet, but at one point it will.
> Is it smart to add the PKGNAMESUFFIX=16 ..?

I would suggest to do it the other way around for as long as the knot 1.x series is the recommended version, and have that be called knot (both in PKGNAME and in dns/knot) and thus have the new beta port as dns/knot2 and knot2 as name suffix.  This can be moved around when 2.x becomes the default version.
Comment 5 Leo Vandewoestijne 2015-05-18 11:00:41 UTC
Aha, yes, that's what I wanted to achieve, as in deed the 1.6 needs to remain the default for now.
(So as you suggested only Knot DNS version 2 should have PKGNAMESUFFIX=2)
Comment 6 commit-hook freebsd_committer 2015-05-18 11:21:44 UTC
A commit references this bug:

Author: erwin
Date: Mon May 18 11:21:07 UTC 2015
New revision: 386670
URL: https://svnweb.freebsd.org/changeset/ports/386670

Log:
  The upstream came with a different temporarily solution than the patch in PR 199298.
  This one allows for GOST in DNSSEC.
  Add conflict with upcoming knot2 port.

  PR:		199866
  Submitted by:	Leo Vandewoestijne <freebsd@dns-lab.com> (maintainer)

Changes:
  head/dns/knot/Makefile
  head/dns/knot/files/patch-src_libknot_dnssec_config.h
  head/dns/knot/files/patch-src_libknot_dnssec_crypto.c
Comment 7 Erwin Lansing freebsd_committer 2015-05-18 11:22:08 UTC
Committed, thanks!