Bug 199939 - books/porters-handbook: typo in USE_GITHUB + DISTVERSIONPREFIX example
Summary: books/porters-handbook: typo in USE_GITHUB + DISTVERSIONPREFIX example
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-doc (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-04 22:36 UTC by Jan Beich
Modified: 2015-06-29 14:08 UTC (History)
2 users (show)

See Also:

Attachments
v0 (787 bytes, patch)
2015-05-04 22:36 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-05-04 22:36:56 UTC 
Created attachment 156352 [details]
v0

USE_GITHUB doesn't touch PORTREVISION at all. What the author meant is probably PORTVERSION. However, using DISTVERSION is more correct because it also fixes unusual versioning (1.5-alpha, 1_2, etc).
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-06-29 14:07:09 UTC 
A commit references this bug:

Author: brueffer
Date: Mon Jun 29 14:06:57 UTC 2015
New revision: 46890
URL: https://svnweb.freebsd.org/changeset/doc/46890

Log:
  USE_GITHUB doesn't touch PORTREVISION at all. What the author meant is
  probably PORTVERSION. However, using DISTVERSION is more correct because
  it also fixes unusual versioning (1.5-alpha, 1_2, etc).

  PR:		199939
  Submitted by:	jbeich
  Reviewed by:	mat (aka "the author")

Changes:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
Comment 2 Christian Brueffer freebsd_committer freebsd_triage 2015-06-29 14:08:16 UTC 
Fixed, thanks!