Bug 200050 - dns/credns: create /var directories from plist
Summary: dns/credns: create /var directories from plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-08 10:58 UTC by Dmitry Marakasov
Modified: 2015-05-09 02:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jaap)

Attachments
Patch (1.91 KB, patch)
2015-05-08 10:58 UTC, Dmitry Marakasov 		no flags Details | Diff
Slightly improved patch (1.92 KB, patch)
2015-05-08 15:57 UTC, Jaap Akkerhuis 		jaap: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-08 10:58:05 UTC 
Created attachment 156505 [details]
Patch

- Currently credns creates /var directories from rc.d script, so there's no way for package system to track them. Instead, create them from plist.
- Strip binaries
- Add LICENSE_FILE
Comment 1 Jaap Akkerhuis 2015-05-08 15:57:49 UTC 
Created attachment 156512 [details]
Slightly improved patch

I tested the proposed patch with poudriere and it needed a small adjustment.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-05-09 02:04:18 UTC 
A commit references this bug:

Author: amdmi3
Date: Sat May  9 02:04:07 UTC 2015
New revision: 385853
URL: https://svnweb.freebsd.org/changeset/ports/385853

Log:
  - Create /var directories from plist, not rc.d script
  - Strip binaries
  - Add LICENSE_FILE

  PR:		200050
  Submitted by:	amdmi3
  Approved by:	jaap@NLnetLabs.nl (maintainer)

Changes:
  head/dns/credns/Makefile
  head/dns/credns/files/credns.in
  head/dns/credns/pkg-plist
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-09 02:05:24 UTC 
You should probably update your poudriere portstree: the ability to omit some keyword argument appeared not long ago, your portstree may be older than this point. Anyway committed your version, thanks!