Bug 200061 - [PATCH] www/kannel: update to 1.4.4, take maintainership
Summary: [PATCH] www/kannel: update to 1.4.4, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-09 03:54 UTC by Danilo G. Baio
Modified: 2015-05-15 20:00 UTC (History)
1 user (show)

See Also:


Attachments
svn_diff_www_kannel_1.4.4 (14.56 KB, patch)
2015-05-09 03:54 UTC, Danilo G. Baio
no flags Details | Diff
UIDs_GIDs_kannel_patch (846 bytes, patch)
2015-05-09 03:57 UTC, Danilo G. Baio
no flags Details | Diff
poudriere testport FreeBSD 10.1 amd64 (152.24 KB, text/plain)
2015-05-09 03:58 UTC, Danilo G. Baio
no flags Details
poudriere testport FreeBSD 10.1 i386 (158.71 KB, text/plain)
2015-05-09 03:58 UTC, Danilo G. Baio
no flags Details
svn_diff_www_kannel_1.4.4_v02 (16.49 KB, patch)
2015-05-13 21:44 UTC, Danilo G. Baio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer 2015-05-09 03:54:42 UTC
Created attachment 156523 [details]
svn_diff_www_kannel_1.4.4

- Update to 1.4.4, set PORTEPOCH because version newest/stable is smalller
 - Add license (The_Kannel_Software_License)
 - Add user/group kannel (patch attached for UIDs and GIDs files)
 - Remove an outdated patch (patch-gwlib__gwthread-pthread.c)
 - Recreate a patch with make makepatch (patch-debian_kannel.conf)
 - Change pkg-description
 - Change pkg-plist
 - Add USES (gcc and bison)
 - split rc script (old rc was not working)
 - portlint compliant
 - poudriere testport logs for FreeBSD 10.1 amd64 and i386 attached.
Comment 1 Danilo G. Baio freebsd_committer 2015-05-09 03:57:00 UTC
Created attachment 156524 [details]
UIDs_GIDs_kannel_patch

Patch for UIDs and GIDs (add user/group kannel)
Comment 2 Danilo G. Baio freebsd_committer 2015-05-09 03:58:01 UTC
Created attachment 156525 [details]
poudriere testport FreeBSD 10.1 amd64
Comment 3 Danilo G. Baio freebsd_committer 2015-05-09 03:58:35 UTC
Created attachment 156526 [details]
poudriere testport FreeBSD 10.1 i386
Comment 4 Dmitry Marakasov freebsd_committer 2015-05-12 00:01:18 UTC
Why is this a downgrade?
Comment 5 Dmitry Marakasov freebsd_committer 2015-05-12 00:13:45 UTC
Disregard that; looks good at the first glance, though I'll review rc.d scripts a bit more. While here, is there a real reason to move logs from /var/log/kannel to /var/log? I think that patch should be removed.
Comment 6 Danilo G. Baio freebsd_committer 2015-05-12 19:12:53 UTC
Thanks for the feedback.
I will remove the "/var/log" patch.
On the sample files the default path for logs is "/tmp". Do you think is better change them?
Best Regards.
Comment 7 Danilo G. Baio freebsd_committer 2015-05-13 21:44:07 UTC
Created attachment 156760 [details]
svn_diff_www_kannel_1.4.4_v02

Patch updated.

   - Updated with last commit.
   - Changed log files path from /tmp to /var/log/kannel on sample files.
   - Added /var/log/kannel and /var/run/kannel directory on pkg-plist @dir and Makefile
   - Removed files/patch-debian__kannel.conf
Comment 8 commit-hook freebsd_committer 2015-05-15 20:00:34 UTC
A commit references this bug:

Author: amdmi3
Date: Fri May 15 19:59:33 UTC 2015
New revision: 386476
URL: https://svnweb.freebsd.org/changeset/ports/386476

Log:
  - Update www/kannel to 1.4.4 (note that it's newer than development version 1.5.0)
  - Add license
  - Add kannel user/group
  - Split and fix rc script
  - Pass maintainership to submitter

  PR:		200061
  Submitted by:	dbaio@bsd.com.br

Changes:
  head/GIDs
  head/UIDs
  head/www/kannel/Makefile
  head/www/kannel/distinfo
  head/www/kannel/files/kannel.in
  head/www/kannel/files/kannel_bearerbox.in
  head/www/kannel/files/kannel_smsbox.in
  head/www/kannel/files/kannel_wapbox.in
  head/www/kannel/files/patch-debian__kannel.conf
  head/www/kannel/files/patch-gw_smskannel.conf
  head/www/kannel/files/patch-gw_wapkannel.conf
  head/www/kannel/files/patch-gwlib__gwthread-pthread.c
  head/www/kannel/pkg-descr
  head/www/kannel/pkg-plist