Created attachment 156677 [details] Revision 282775. I'd like to request an exp-run with the attached patch so that we can find out how many ports would be affected by it (i.e. linking against liblzma statically).
Assign to portmgr@ for exp-run.
Exp-run results: http://package23.nyi.freebsd.org/build.html?mastername=headamd64PR200142-default&build=2015-05-12_09h25m35s Failure log: http://package23.nyi.freebsd.org/data/headamd64PR200142-default/2015-05-12_09h25m35s/logs/errors/pkg-1.5.2.log Also, liblzma.pc and libarchive.pc may need adjustments?
exp-run ran, assign back to submitter.
What's next here?
Created attachment 214505 [details] New patch against -HEAD
Hi, May I request for a new exp-run just in case this would have broke something? The new patch is available at https://reviews.freebsd.org/D24805 and attached for your convenience.
Ping?
Created attachment 214775 [details] Updated patch against -HEAD
Created attachment 214776 [details] Patch for ports-mgmt/pkg to fix pkg-static build
(In reply to Xin LI from comment #9) so it was broken? I don't think that such change that break even pkg are welcome..
(In reply to Antoine Brodin from comment #10) ports-mgmt/pkg fails to use pkg-config provided linker flags when building static binary because it hardcoded the library list by default, but the dynamically linked binaries are fine (rtld would correctly load libmd).
And I am not sure that removing symbols from Symbol.map is allowed.
(In reply to Antoine Brodin from comment #12) These are private symbols, removal of private symbols are generally considered as acceptable and we do remove them all the times (r359930, r359460, r341509 are most recent ones for libc). The removed symbols were never defined in the public headers anyway.
New failure log on i386: http://package23.nyi.freebsd.org/data/headi386PR200142-default/2020-05-28_07h36m20s/logs/errors/pkg-devel-1.14.99.1.log
Created attachment 215029 [details] Patch for ports-mgmt/pkg-devel to fix liblzma.pc usage Thanks, here is the fix for the build issue
Is there any additional breakage? I'd like to commit the -HEAD change by next week.
A commit references this bug: Author: delphij Date: Sat Jun 20 21:22:55 UTC 2020 New revision: 539750 URL: https://svnweb.freebsd.org/changeset/ports/539750 Log: ports-mgmt/pkg: Respect liblzma.pc if available. Note that this is meant to be a temporary hack and will be reverted once the freebsd/pkg have solved this in the build infrastructure. PR: 200142 MFH: 2020Q2 Approved by: portmgr (bapt over IRC) Differential Revision: https://reviews.freebsd.org/D24972 Changes: head/ports-mgmt/pkg/Makefile
A commit references this bug: Author: delphij Date: Sat Jun 20 21:23:03 UTC 2020 New revision: 539751 URL: https://svnweb.freebsd.org/changeset/ports/539751 Log: ports-mgmt/pkg-devel: Respect liblzma.pc if available. Note that this is meant to be a temporary hack and will be reverted once the freebsd/pkg have solved this in the build infrastructure. PR: 200142 MFH: 2020Q2 Approved by: portmgr (bapt over IRC) Differential Revision: https://reviews.freebsd.org/D25053 Changes: head/ports-mgmt/pkg-devel/Makefile
A commit references this bug: Author: delphij Date: Sat Jun 20 21:26:47 UTC 2020 New revision: 539752 URL: https://svnweb.freebsd.org/changeset/ports/539752 Log: MFH: r539750 r539751 ports-mgmt/pkg: Respect liblzma.pc if available. ports-mgmt/pkg-devel: Respect liblzma.pc if available. Note that this is meant to be a temporary hack and will be reverted once the freebsd/pkg have solved this in the build infrastructure. PR: 200142 Approved by: portmgr (bapt over IRC) Changes: _U branches/2020Q2/ branches/2020Q2/ports-mgmt/pkg/Makefile branches/2020Q2/ports-mgmt/pkg-devel/Makefile
A commit references this bug: Author: delphij Date: Sat Jun 20 21:32:08 UTC 2020 New revision: 362452 URL: https://svnweb.freebsd.org/changeset/base/362452 Log: liblzma: Make liblzma use libmd implementation of SHA256. MFC after: 2 weeks PR: 200142 Changes: head/contrib/xz/src/liblzma/check/sha256.c head/lib/liblzma/Makefile head/lib/liblzma/Symbol.map head/lib/liblzma/config.h head/share/mk/src.libnames.mk
A commit references this bug: Author: delphij Date: Sat Jun 20 21:32:14 UTC 2020 New revision: 362453 URL: https://svnweb.freebsd.org/changeset/base/362453 Log: Bump __FreeBSD_version after making liblzma to use libmd implementation of SHA256. PR: 200142 Changes: head/sys/sys/param.h