Created attachment 156677 [details]
I'd like to request an exp-run with the attached patch so that we can find out how many ports would be affected by it (i.e. linking against liblzma statically).
Assign to portmgr@ for exp-run.
Also, liblzma.pc and libarchive.pc may need adjustments?
exp-run ran, assign back to submitter.
What's next here?
Created attachment 214505 [details]
New patch against -HEAD
May I request for a new exp-run just in case this would have broke something? The new patch is available at https://reviews.freebsd.org/D24805 and attached for your convenience.
Created attachment 214775 [details]
Updated patch against -HEAD
Created attachment 214776 [details]
Patch for ports-mgmt/pkg to fix pkg-static build
(In reply to Xin LI from comment #9)
so it was broken?
I don't think that such change that break even pkg are welcome..
(In reply to Antoine Brodin from comment #10)
ports-mgmt/pkg fails to use pkg-config provided linker flags when building static binary because it hardcoded the library list by default, but the dynamically linked binaries are fine (rtld would correctly load libmd).
And I am not sure that removing symbols from Symbol.map is allowed.
(In reply to Antoine Brodin from comment #12)
These are private symbols, removal of private symbols are generally considered as acceptable and we do remove them all the times (r359930, r359460, r341509 are most recent ones for libc).
The removed symbols were never defined in the public headers anyway.