Bug 200146 - java/wildfly90: permission and configuration fixes
Summary: java/wildfly90: permission and configuration fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-05-12 09:45 UTC by Jimmy Olgeni
Modified: 2015-05-18 23:33 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yerenkow)


Attachments
Patch for wildfly90 (4.89 KB, patch)
2015-05-12 09:45 UTC, Jimmy Olgeni
no flags Details | Diff
Patch for wildfly82 (4.89 KB, patch)
2015-05-12 09:46 UTC, Jimmy Olgeni
no flags Details | Diff
Patch for wildfly81 (4.89 KB, patch)
2015-05-12 09:46 UTC, Jimmy Olgeni
no flags Details | Diff
Patch for wildfly80 (4.89 KB, patch)
2015-05-12 09:56 UTC, Jimmy Olgeni
no flags Details | Diff
poudriere test run for wildfly90 (32.54 KB, text/x-log)
2015-05-12 09:58 UTC, Jimmy Olgeni
no flags Details
poudriere test run for wildfly82 (32.47 KB, text/x-log)
2015-05-12 09:58 UTC, Jimmy Olgeni
no flags Details
poudriere test run for wildfly81 (32.47 KB, text/x-log)
2015-05-12 09:58 UTC, Jimmy Olgeni
no flags Details
poudriere test run for wildfly80 (32.47 KB, text/x-log)
2015-05-12 09:59 UTC, Jimmy Olgeni
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer 2015-05-12 09:45:50 UTC
Created attachment 156686 [details]
Patch for wildfly90

Hi,

A couple of fixes I missed last time for all wildfly ports:

- Install configuration files using @sample to avoid overwriting
- Use permission 600 for configuration files (for user management, etc.)
Comment 1 Jimmy Olgeni freebsd_committer 2015-05-12 09:46:12 UTC
Created attachment 156687 [details]
Patch for wildfly82
Comment 2 Jimmy Olgeni freebsd_committer 2015-05-12 09:46:31 UTC
Created attachment 156688 [details]
Patch for wildfly81
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-12 09:51:28 UTC
Submitter is committer, assign accordingly

Jimmy, could these ports benefit from a MASTER/SLAVE structure given the common content?
Comment 4 Jimmy Olgeni freebsd_committer 2015-05-12 09:56:13 UTC
Created attachment 156690 [details]
Patch for wildfly80
Comment 5 Jimmy Olgeni freebsd_committer 2015-05-12 09:57:52 UTC
(In reply to Kubilay Kocak from comment #3)

Network down mid-PR, some stuff was missing.

Maybe it could become a MASTER/SLAVE port, but I don't know enough about it to make promises right now :)
Comment 6 Jimmy Olgeni freebsd_committer 2015-05-12 09:58:18 UTC
Created attachment 156691 [details]
poudriere test run for wildfly90
Comment 7 Jimmy Olgeni freebsd_committer 2015-05-12 09:58:36 UTC
Created attachment 156692 [details]
poudriere test run for wildfly82
Comment 8 Jimmy Olgeni freebsd_committer 2015-05-12 09:58:55 UTC
Created attachment 156693 [details]
poudriere test run for wildfly81
Comment 9 Jimmy Olgeni freebsd_committer 2015-05-12 09:59:16 UTC
Created attachment 156694 [details]
poudriere test run for wildfly80
Comment 10 yerenkow 2015-05-18 06:38:11 UTC
Ok, now seems changed files maintained properly. Good for me :)
Comment 11 commit-hook freebsd_committer 2015-05-18 23:29:10 UTC
A commit references this bug:

Author: olgeni
Date: Mon May 18 23:28:55 UTC 2015
New revision: 386724
URL: https://svnweb.freebsd.org/changeset/ports/386724

Log:
  Install configuration files using @sample, with permissions 600.

  PR:		200146
  Submitted by:	olgeni
  Approved by:	maintainer

Changes:
  head/java/wildfly80/Makefile
  head/java/wildfly80/pkg-plist
  head/java/wildfly81/Makefile
  head/java/wildfly81/pkg-plist
  head/java/wildfly82/Makefile
  head/java/wildfly82/pkg-plist
  head/java/wildfly90/Makefile
  head/java/wildfly90/pkg-plist
Comment 12 Jimmy Olgeni freebsd_committer 2015-05-18 23:33:20 UTC
Patch committed :)