Bug 200168 - [PATCH] net/turnserver: update to 4.4.4.2
Summary: [PATCH] net/turnserver: update to 4.4.4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-13 12:06 UTC by Bradley T. Hughes
Modified: 2015-05-19 21:53 UTC (History)
2 users (show)

See Also:
mom040267: maintainer-feedback+


Attachments
patch (11.37 KB, text/plain)
2015-05-13 12:06 UTC, Bradley T. Hughes
no flags Details
poudriere build log (53.16 KB, text/plain)
2015-05-13 12:07 UTC, Bradley T. Hughes
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer freebsd_triage 2015-05-13 12:06:52 UTC
Created attachment 156748 [details]
patch

Update to the next major version of the turnserver (called coturn). Attached are a patch (as a git commit) to the port itself, as well as a poudriere build log.
Comment 1 Bradley T. Hughes freebsd_committer freebsd_triage 2015-05-13 12:07:23 UTC
Created attachment 156749 [details]
poudriere build log
Comment 2 mom040267 2015-05-13 16:41:56 UTC
I approve the upgrade.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2015-05-13 22:31:34 UTC
Hi,

Since the upstream project has forked itself we have three options:

1 - Update turnserver to the latest version (which is really named coturn)
2 - move net/turnserver to net/coturn and update the new one
3 - copy net/turnserver to net/coturn, update coturn and keep both

Which one do you(the maintainer) think is the best one?

If turnserver has been really abandoned then I'd take 2, if turnserver is still maintained I'd rather do 3. I think option 1 isn't really the best course of action.

Thanks.
Comment 4 Bradley T. Hughes freebsd_committer freebsd_triage 2015-05-18 05:59:51 UTC
The patch to upgrade net/turnserver to coturn v4.x was done at the request of the maintainer after an email discussion on the matter, since the package and executable are called "turnserver," despite the name of the project(s).
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-05-18 17:27:19 UTC
A commit references this bug:

Author: madpilot
Date: Mon May 18 17:27:04 UTC 2015
New revision: 386693
URL: https://svnweb.freebsd.org/changeset/ports/386693

Log:
  Update net/turnserver to 4.4.4.2

  PR:		200168
  Submitted by:	Bradley T. Hughes <bradleythughes at fastmail.fm>
  Approved by:	mom040267@gmail.com (maintainer)

Changes:
  head/net/turnserver/Makefile
  head/net/turnserver/distinfo
  head/net/turnserver/files/pkg-message.in
  head/net/turnserver/pkg-descr
  head/net/turnserver/pkg-plist
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2015-05-18 17:28:15 UTC
Committed, Thanks.

I fixed the plist to correctly package the port when SQLITE support was disabled.

I also sorted options, since they were reshuffled already.
Comment 7 Bradley T. Hughes freebsd_committer freebsd_triage 2015-05-19 21:53:25 UTC
Thanks!