Bug 200234 - graphics/opencv-core incorrect optimization flag
Summary: graphics/opencv-core incorrect optimization flag
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-16 01:33 UTC by sasamotikomi
Modified: 2015-06-14 15:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jhale)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sasamotikomi 2015-05-16 01:33:52 UTC
-- General configuration for OpenCV 2.4.9 =====================================
--   Version control:               unknown
-- 
--   Platform:
--     Host:                        FreeBSD 10.1-RELEASE-p9 i386
--     CMake:                       3.1.3
--     CMake generator:             Unix Makefiles
--     CMake build tool:            /usr/local/bin/gmake
--     Configuration:               Release
-- 
--   C/C++:
--     Built as dynamic libs?:      YES
--     C++ Compiler:                /usr/bin/c++  (ver 3.4.1)
--     C++ flags (Release):         -O2 -pipe -march=athlon-xp -fstack-protector -fno-strict-aliasing   -fsigned-char -W -Werror=return-type -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wno-narrowing -Wno-delete-non-virtual-dtor -Wno-unnamed-type-template-args -fdiagnostics-show-option -pthread -march=i686 -fomit-frame-pointer -msse -msse2 -msse3 -ffunction-sections -O2 -pipe -march=athlon-xp -fstack-protector -fno-strict-aliasing  -DNDEBUG
--     C++ flags (Debug):           -O2 -pipe -march=athlon-xp -fstack-protector -fno-strict-aliasing   -fsigned-char -W -Werror=return-type -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wno-narrowing -Wno-delete-non-virtual-dtor -Wno-unnamed-type-template-args -fdiagnostics-show-option -pthread -march=i686 -fomit-frame-pointer -msse -msse2 -msse3 -ffunction-sections -O2 -pipe -march=athlon-xp -fstack-protector -fno-strict-aliasing  -O0 -DDEBUG -D_DEBUG
--     C Compiler:                  /usr/bin/cc
--     C flags (Release):           -O2 -pipe -march=athlon-xp  -fstack-protector -fno-strict-aliasing   -fsigned-char -W -Werror=return-type -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wno-narrowing -Wno-delete-non-virtual-dtor -Wno-unnamed-type-template-args -fdiagnostics-show-option -pthread -march=i686 -fomit-frame-pointer -msse -msse2 -msse3 -ffunction-sections -O2 -pipe -march=athlon-xp  -fstack-protector -fno-strict-aliasing  -DNDEBUG
--     C flags (Debug):             -O2 -pipe -march=athlon-xp  -fstack-protector -fno-strict-aliasing   -fsigned-char -W -Werror=return-type -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wno-narrowing -Wno-delete-non-virtual-dtor -Wno-unnamed-type-template-args -fdiagnostics-show-option -pthread -march=i686 -fomit-frame-pointer -msse -msse2 -msse3 -ffunction-sections -O2 -pipe -march=athlon-xp  -fstack-protector -fno-strict-aliasing  -O0 -DDEBUG -D_DEBUG
--     Linker flags (Release):      -fstack-protector
--     Linker flags (Debug):        -fstack-protector

Doubled -O0/O2, -march my(CPUTYPE) and included,-fno-strict-aliasing, -pipe flag, SSE2 only supported by one of all 32-bit processor (Pentium 4), SSE3 isn't supported all x86-32 and some x86-64 processor.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-06-14 15:28:12 UTC
A commit references this bug:

Author: jhale
Date: Sun Jun 14 15:28:04 UTC 2015
New revision: 389642
URL: https://svnweb.freebsd.org/changeset/ports/389642

Log:
  - Add SIMD option to specifically disable CPU optimizations and prevent crashes
    with ffmpeg on processors that do not support SSE instructions.  OFF by
    default for package building, ON with autodetect for ports to keep with
    POLA. [1][2]
  - Bump PORTREVISION on all opencv ports

  PR:		199715 [1], 200234 [2]
  Submitted by:	Randy Westlund <rwestlun@gmail.com> [1], sasamotikomi@gmail.com [2]

Changes:
  head/graphics/opencv/Makefile
  head/graphics/opencv-core/Makefile
  head/graphics/opencv-java/Makefile
  head/graphics/py-opencv/Makefile
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2015-06-14 15:40:25 UTC
The incorrect cpu flags should be fixed now in r389642.  As far as the -O0/-O2 thing, if -DWITH_DEBUG is set, the extra -O2's are removed by the ports system so it shouldn't be an issue.  I'm closing this in favor of bug 199715 to track the cpu flag issue.