Created attachment 156837 [details] patch to remove pre-everything check that always fails (wrongly) in some scenarios On a system without base sendmail installed, and no explicit "WITH_SENDMAIL_(BASE|PORT)" defined, the port will not build because it fails at the sanity check. the "WITH_SENDMAIL_PORT" is the default when it's not defined, and the BUILD_DEPENDS and RUN_DEPENDS are appropriately set to pull in sendmail's milter library. However, that library is not in place when "pre-everything" target is run, so the existence check for the library fails 100% of the time. I don't really see the value in the check at all. The attached patch removes it completely. The worst case scenario is somebody changes default options on sendmail that cause this port to break during building. That's an edge case I think.
any feedback on this yet? The PR times out in a few days...
I'm working on solution.
but what is the problem you are trying to solve?
How to properly check for libmilter libraries and include files in your scenario.
well, so far the check has never worked and nobody complained, so why do it? What happens in the worst case if you don't check? Very few ports use "pre-everything" target.
This weekend I released new version amavisd-milter-1.6.1 and now I'm upgrading FreeBSD port. I want to solve your problem too. Please be a little patient.
but my problem is the check itself. No check = no problem. From the beginning I've been trying to understand what actually this check was intended to prevent. To trip the intention of the check, somebody would have to intentionally disable sendmail's milter (it's on by default). So what happens in that case? The port breaks during the build? That's the worst that can happen?
There's been no action on this PR for 6 weeks.
Reporter is committer, assign accordingly. Maintainer timeout 6 weeks, implicit approval
A commit references this bug: Author: marino Date: Fri Jul 3 09:20:25 UTC 2015 New revision: 391224 URL: https://svnweb.freebsd.org/changeset/ports/391224 Log: security/amavisd-milter: Remove pre-everything check The pre-everything target fails on systems that do not have sendmail installed in base. The logic may have worked in the past, but today the existence check fails because the library that is checked is pulled in later. The check itself is aimed at the sysadmin that intentionally changes the sendmail default to not install milter, but then tries to install this port. The worst case scenario the results from removing this check (even if it worked) is that the amavisd-milter port breaks during the build. PR: 200247 Submitted by: marino Approved by: maintainer timeout (6 weeks) Changes: head/security/amavisd-milter/Makefile