Bug 200324 - [maintainer] finance/electrum: Upgrade to 2.2
Summary: [maintainer] finance/electrum: Upgrade to 2.2
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 11:06 UTC by kyuupichan
Modified: 2015-05-26 15:46 UTC (History)
1 user (show)

See Also:


Attachments
Diff of the upgrade of port to 2.2 (1.66 KB, patch)
2015-05-19 11:06 UTC, kyuupichan
no flags Details | Diff
shar file of the upgrade of port to 2.2 (16.09 KB, text/plain)
2015-05-19 11:07 UTC, kyuupichan
no flags Details
Build log (79.67 KB, text/plain)
2015-05-22 10:52 UTC, Dmitry Marakasov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description kyuupichan 2015-05-19 11:06:32 UTC
Created attachment 156931 [details]
Diff of the upgrade of port to 2.2

Simple upgrade to 2.2, just released
Comment 1 kyuupichan 2015-05-19 11:07:27 UTC
Created attachment 156932 [details]
shar file of the upgrade of port to 2.2
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-21 11:19:00 UTC
It fails complaining on Electrum-2.2-py%%PYTHON_VER%%.egg-info/* entries. Probably these are handled by python framework and should not be in plist.
Comment 3 kyuupichan 2015-05-22 01:44:32 UTC
Do those lines in the plist cause an issue?  The files are installed with the package, and are placed in the plist by make makeplist.  Having them there doesn't cause any warning or error for me.

Unfortunately the "python framework" you refer to seems to be completely undocumented, but if it doesn't like them in the plist I would suggest the framework be updated to not put them in the plist.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-22 10:52:29 UTC
Created attachment 157031 [details]
Build log

As I've said, in result the port doesn't build, so yes, this creates an issue. See attached log - there's also line that adds them to plist automatically, so egg-info/* should just be removed from normal plist.
Comment 5 kyuupichan 2015-05-25 12:45:06 UTC
I don't get errors, but I do get a duplicate file warning.  Somehow I missed that.

But to me this is a bug in make makeplist that should be fixed.  Otherwise anyone creating a python package has to duplicate the same workaround - removing egg files.  Which is wasteful.

I'll wait for 2.2.1 as it turns out 2.2 had a couple of unfortunate bugs.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-26 15:46:06 UTC
(In reply to kyuupichan from comment #5)

> But to me this is a bug in make makeplist that should be fixed.  Otherwise anyone creating a python package has to duplicate the same workaround - removing egg files.  Which is wasteful.

There may be a bug in makeplist, but fixing it may be even more wasteful as it may require duplicating some make logic. It is mandatory to test your changes in poudriere before submitting them, and this will reveal problems like this. Please do that with next submission. I'm closing this bug if we're not updating to 2.2.