Bug 200331 - [MAINTAINER] www/mod_geoip2: Modernize Makefile
Summary: [MAINTAINER] www/mod_geoip2: Modernize Makefile
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2015-05-19 15:00 UTC by jau
Modified: 2015-06-16 08:52 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (jau)

Attachments
patch to Makefile (1.52 KB, patch)
2015-05-19 15:00 UTC, jau 		no flags Details | Diff
the complete modified Makefile (968 bytes, text/plain)
2015-05-19 15:32 UTC, jau 		jau: maintainer-approval+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jau 2015-05-19 15:00:08 UTC 
Created attachment 156945 [details]
patch to Makefile

The old Makefile was kind of clumsy.
The new one is slightly better.
This port has in any case been lacking
maintenance for too long now.
So, I guess it is the time to do something.
Comment 1 jau 2015-05-19 15:32:09 UTC 
Created attachment 156947 [details]
the complete modified Makefile

Argh... I just dropped in a patch to the Makefile.
And obviously I have wrong patch file with the same name on another system.
So, this is patching a patch ...
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-20 09:45:15 UTC 
Attachment 156945 [details] doesn't appear to be a diff. 

Can you attach a new patch produced via `svn diff` or diff -U please
Comment 3 jau 2015-06-16 08:52:53 UTC 
There should be already a patch in the works to update 1.2.9 to 1.2.10.
See bug id 200735.
Anything related to 1.2.9 is in fact irrelevant already.