Bug 200452 - [PATCH] devel/pear-Net_Gearman: Fix bug does not properly send priority high job
Summary: [PATCH] devel/pear-Net_Gearman: Fix bug does not properly send priority high job
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-05-26 04:27 UTC by Gasol Wu
Modified: 2015-05-27 06:16 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
patch (1.08 KB, patch)
2015-05-26 04:27 UTC, Gasol Wu
no flags Details | Diff
patch (2.16 KB, patch)
2015-05-26 16:35 UTC, Gasol Wu
koobs: maintainer-approval+
Details | Diff
testport result (13.58 KB, text/plain)
2015-05-26 16:36 UTC, Gasol Wu
no flags Details
portlint (12 bytes, text/plain)
2015-05-26 16:36 UTC, Gasol Wu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2015-05-26 04:27:43 UTC
Created attachment 157147 [details]
patch

- Fix constant JOB_HIGH that share same value with JOB_NORMAL
- Bump PORTREVISION from 1 to 2
- Correct indent of USES

This bug was introduced half and fixed half decade ago, But upstream doesn't release new version against it. Please also see the following changes for details.

https://github.com/brianlmoon/net_gearman/commit/990519aa62688828cd058b981e1942521f0acffe
Comment 1 Gasol Wu 2015-05-26 04:32:52 UTC
I'm heavily use this port on work, So I would like to take maintainership for further support.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-26 10:10:27 UTC
Gasul, please replace the current attachment with a new one setting yourself as MAINTAINER, and include QA results as well if possible (portlint -AC, poudriere)

Thank you for offering to take maintainership :)
Comment 3 Gasol Wu 2015-05-26 16:35:39 UTC
Created attachment 157168 [details]
patch

update MAINTAINER
Comment 4 Gasol Wu 2015-05-26 16:36:28 UTC
Created attachment 157169 [details]
testport result
Comment 5 Gasol Wu 2015-05-26 16:36:55 UTC
Created attachment 157170 [details]
portlint
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-27 04:49:33 UTC
Comment on attachment 157168 [details]
patch

Implicit maintainer approval (port unmaintained)
Comment 7 commit-hook freebsd_committer 2015-05-27 05:21:42 UTC
A commit references this bug:

Author: koobs
Date: Wed May 27 05:21:06 UTC 2015
New revision: 387541
URL: https://svnweb.freebsd.org/changeset/ports/387541

Log:
  devel/pear-Net_Gearman: Take MAINTAINER'ship, Fix Bug

  - Assign MAINTAINER'ship (Thank you Gasol!)
  - Fix JOB_HIGH constant that shares the same value as JOB_NORMAL

  This bug was introduced and fixed [1] in 2009, but upstream has not
  released a new version.

  - Bump PORTREVISION
  - Correct indent of USES

  [1] https://github.com/brianlmoon/net_gearman/commit/990519aa62688828cd058b981e1942521f0acffe

  PR:		200452
  Submitted by:	Gasol Wu <gasol dot wu gmail com>

Changes:
  head/devel/pear-Net_Gearman/Makefile
  head/devel/pear-Net_Gearman/files/patch-Net_Gearman_Task.php
  head/devel/pear-Net_Gearman/files/patch-Net__Gearman__Client.php
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-05-27 05:23:03 UTC
Committed, thanks Gasol!

For what it's worth, I would encourage upstream to produce a new release.
Comment 9 Gasol Wu 2015-05-27 06:16:39 UTC
(In reply to Kubilay Kocak from comment #8)

I did, but no response.