Bug 200464 - devel/automake14: fix for perl5.20
Summary: devel/automake14: fix for perl5.20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: autotools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-26 14:57 UTC by Christian Weisgerber
Modified: 2015-05-26 19:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (autotools)


Attachments
automake14.patch (1.48 KB, patch)
2015-05-26 14:57 UTC, Christian Weisgerber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer freebsd_triage 2015-05-26 14:57:59 UTC
Created attachment 157160 [details]
automake14.patch

Now that the default Perl has been switched to 5.20, we should fix the automake14 port to work with this version.
 
To quote perl5200delta(1):
 
Incompatible Changes
   "do" can no longer be used to call subroutines
       The "do SUBROUTINE(LIST)" form has resulted in a deprecation warning
       since Perl v5.0.0, and is now a syntax error.

Patch attached.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2015-05-26 15:24:50 UTC
Feel free to commit.  Do you still have a use for this port?  It isn't used by anything in the ports tree and I've been thinking of marking it deprecated.
Comment 2 Christian Weisgerber freebsd_committer freebsd_triage 2015-05-26 19:21:36 UTC
No, I don't have a use for this port. I originally found and fixed this problem on OpenBSD.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-05-26 19:23:47 UTC
A commit references this bug:

Author: naddy
Date: Tue May 26 19:22:49 UTC 2015
New revision: 387512
URL: https://svnweb.freebsd.org/changeset/ports/387512

Log:
  Fix for perl 5.20, which has dropped the "do $subr()" construct.

  PR:		200464
  Reviewed by:	tijl

Changes:
  head/devel/automake14/Makefile
  head/devel/automake14/files/patch-automake.in