Bug 200489 - tests/sys/kern/ptrace_test.c:375: wpid == child not met
Summary: tests/sys/kern/ptrace_test.c:375: wpid == child not met
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: John Baldwin
URL: https://reviews.freebsd.org/D2674
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-28 03:12 UTC by Enji Cooper
Modified: 2015-05-31 19:44 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2015-05-28 03:12:24 UTC 
From
https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1063/testReport/sys.kern/ptrace_test/ptrace__parent_sees_exit_after_unrelated_debugger/ :

/builds/FreeBSD_HEAD/tests/sys/kern/ptrace_test.c:375: wpid == child not met
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2015-05-28 04:36:15 UTC 
Frequency:
https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1061/
Comment 2 Craig Rodrigues freebsd_committer freebsd_triage 2015-05-28 05:58:17 UTC 
This test started failing with this batch of commits:

https://jenkins.freebsd.org/job/FreeBSD_HEAD/2800/

This commit looks like the cause:
https://svnweb.freebsd.org/base?view=revision&revision=283562

jhb, can you look?
Comment 3 Craig Rodrigues freebsd_committer freebsd_triage 2015-05-28 08:36:34 UTC 
The test doesn't always fail, but I can reproduce the test failure
if I run it in a loop:

cd /usr/tests
while true
do
    kyua test sys/kern/ptrace_test
    if [ $? -ne 0 ]
    then
        break
    fi
done
Comment 4 John Baldwin freebsd_committer freebsd_triage 2015-05-30 18:52:52 UTC 
Patch posted for review.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-05-31 19:44:17 UTC 
A commit references this bug:

Author: jhb
Date: Sun May 31 19:43:36 UTC 2015
New revision: 283836
URL: https://svnweb.freebsd.org/changeset/base/283836

Log:
  Consistently only use one end of the pipe in the parent and debugger
  processes and do not rely on EOF due to a close() in the debugger.

  PR:		200489
  Differential Revision:	https://reviews.freebsd.org/D2674
  Reviewed by:	kib, ngie, rodrigc

Changes:
  head/tests/sys/kern/ptrace_test.c