Bug 200683 - [maintainer-update] science/orthanc update 0.8.6 to 0.9.0
Summary: [maintainer-update] science/orthanc update 0.8.6 to 0.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-06 21:21 UTC by mp39590
Modified: 2015-06-22 18:47 UTC (History)
1 user (show)

See Also:


Attachments
patch (19.05 KB, patch)
2015-06-06 21:21 UTC, mp39590
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mp39590 2015-06-06 21:21:16 UTC
Created attachment 157485 [details]
patch

- update from 0.8.6 to 0.9.0
- mark as ignored for anything except 10.1
- run unit tests during port build
- fix config installation

Note to committer: please, remove everything in files/ except orthanc.in and patch-Resources_Configuration.json - it's in upstream now.

Two Unit tests are failing in 8.4 and 9.3, it looks like boost has some problems with converting charsets in those tests. Since upstream only supports 10.1 - mark IGNORE for anything else for now, the software actually runs fine on 11, but unit tests are failing too (cause is known for that case).
Comment 1 commit-hook freebsd_committer 2015-06-19 02:25:11 UTC
A commit references this bug:

Author: wen
Date: Fri Jun 19 02:24:09 UTC 2015
New revision: 390100
URL: https://svnweb.freebsd.org/changeset/ports/390100

Log:
  - Update from 0.8.6 to 0.9.0
  - Mark as ignored for anything except 10.1
  - Run unit tests during port build
  - Fix config installation

  PR:		200683
  Submitted by:	mp39590@gmail.com(maintainer)

Changes:
  head/science/orthanc/Makefile
  head/science/orthanc/distinfo
  head/science/orthanc/files/patch-CMakeLists.txt
  head/science/orthanc/files/patch-Core_Compression_HierarchicalZipWriter.cpp
  head/science/orthanc/files/patch-Core_ImageFormats_ImageProcessing.cpp
  head/science/orthanc/files/patch-Core_MultiThreading_Mutex.cpp
  head/science/orthanc/files/patch-Core_MultiThreading_ThreadedCommandProcessor.cpp
  head/science/orthanc/files/patch-Core_Toolbox.cpp
  head/science/orthanc/files/patch-OrthancServer_Internals_StoreScp.cpp
  head/science/orthanc/files/patch-Plugins_Engine_PluginsManager.cpp
  head/science/orthanc/files/patch-Plugins_Engine_SharedLibrary.cpp
  head/science/orthanc/files/patch-Resources_CMake_AutoGeneratedCode.cmake
  head/science/orthanc/files/patch-Resources_CMake_BoostConfiguration.cmake
  head/science/orthanc/files/patch-Resources_CMake_Compiler.cmake
  head/science/orthanc/files/patch-Resources_CMake_SQLiteConfiguration.cmake
  head/science/orthanc/pkg-plist
Comment 2 Dmitry Marakasov freebsd_committer 2015-06-19 11:06:31 UTC
Second IGNORE should be BROKEN instead. IGNORE means "it should not work", BROKEN means "it should work, but it doesn't".
Comment 3 mp39590 2015-06-22 18:47:51 UTC
(In reply to Dmitry Marakasov from comment #2)
> Second IGNORE should be BROKEN instead. IGNORE means "it should not work",
> BROKEN means "it should work, but it doesn't".

It looks like author of the software want to move away from sourceforge, so I'm planning an update of the port in near future, I'll replace second IGNORE with BROKEN at that time.