Bug 200685 - [maintainer] www/h2o r387352 breaks 1.0.1 build in branches/2015Q2
Summary: [maintainer] www/h2o r387352 breaks 1.0.1 build in branches/2015Q2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords: easy, needs-qa, patch, patch-ready, regression
Depends on:
Blocks:
 
Reported: 2015-06-06 22:19 UTC by Dave Cottlehuber
Modified: 2015-06-19 17:49 UTC (History)
2 users (show)

See Also:

Attachments
effectively reverts the patch form r287352 (433 bytes, patch)
2015-06-06 22:25 UTC, Dave Cottlehuber 		dch: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2015-06-06 22:19:53 UTC 
the shebangfix applied in r387352 breaks the quarterly
branch as this file is not present until h2o 1.2.0.
Package & port builds on all platforms are failing viz

http://beefy3.nyi.freebsd.org/data/93i386-quarterly/388421/logs/errors/h2o-1.0.1_1.log

```
===>  Extracting for h2o-1.0.1_1
=> SHA256 Checksum OK for h2o-1.0.1.tar.gz.
===========================================================================
=======================<phase: patch-depends  >============================
===========================================================================
=======================<phase: patch          >============================
===>  Patching for h2o-1.0.1_1
sed: share/h2o/start_server: No such file or directory
*** [fix-shebang] Error code 1

Stop in /usr/ports/www/h2o.
```

This commmit should be reverted for this branch only.
Comment 1 Dave Cottlehuber freebsd_committer freebsd_triage 2015-06-06 22:25:07 UTC 
Created attachment 157486 [details]
effectively reverts the patch form r287352

Removes only the SHEBANG_FILES line in Makefile and bumps PORTREVISION.
Not clear if ports-secteam need to approve.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-19 16:26:45 UTC 
Assign to committer of revision 387352 for revert
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-06-19 16:51:30 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Jun 19 16:50:55 UTC 2015
New revision: 390134
URL: https://svnweb.freebsd.org/changeset/ports/390134

Log:
  - Revert r388419 unbreaking the build

  PR:		200685
  Submitted by:	dch@skunkwerks.at (maintainer)
  Approved by:	ports-secteam (build fix blanket)

Changes:
  branches/2015Q2/www/h2o/Makefile
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-19 17:49:49 UTC 
Reverted, sorry for the breakage.