Bug 200706 - www/entrans: style fixes, modernize plist
Summary: www/entrans: style fixes, modernize plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-07 22:31 UTC by Dmitry Marakasov
Modified: 2015-07-02 11:54 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (prudhvi-krishna-bsd)

Attachments
Patch (1.61 KB, patch)
2015-06-07 22:31 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-07 22:31:50 UTC 
Created attachment 157530 [details]
Patch

- Don't needlessly set WRKSRC to its default value
- Add NO_ARCH
- Fix WWW:
- Other style fixes
- Modernize plist: switch to @dir
- Remove useless chown: changing owner of only top-level directory doesn't make sense. Changing owener of cache and log dirs would make sence though, if it's needed please do it.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-07-02 11:54:13 UTC 
A commit references this bug:

Author: robak
Date: Thu Jul  2 11:53:58 UTC 2015
New revision: 391135
URL: https://svnweb.freebsd.org/changeset/ports/391135

Log:
  www/entrans: various fixes and cleanup

  - Don't needlessly set WRKSRC to its default value
  - Add NO_ARCH
  - Fix WWW
  - Modernize plist: switch to @dir
  - Remove useless chown
  - Pet portlint

  PR:		200706
  Submitted by:	amdmi3
  Approved by:	maintainer timeout  (25 days)

Changes:
  head/www/entrans/Makefile
  head/www/entrans/pkg-descr
Comment 2 Bartek Rutkowski freebsd_committer freebsd_triage 2015-07-02 11:54:54 UTC 
Committed, thanks for your work!