Created attachment 157572 [details] patch to fix three problems in net-mgmt/rancid the attached patch fixes the following problems with net-mgmt/rancid: - back-port a patch from 3.2 to 2.3.8 to make ipv6 prefix-lists sort properly, which is broken in perl >=5.18 due to hash randomisation changes - fix for ASR9001 XR, which updates 3 hard disk files on a regular basis (uptime_cont, temp_cont, volt_cont), which causes excessive output noise - change the timing parameters for foundry networks equipment (brocade) so that it doesn't take eternity to make configuration changes on multiple switches.
Approved
Thanks for your submission Nick, and for approving Janos. Could you provide (as attachments) the following QA results please: * portlint -AC output * poudriere testport (or bulk -t) output Also, will these be, or have you submitted these changes upstream as issues or PR's?
Created attachment 158293 [details] portlint output
Created attachment 158294 [details] poudriere output
Created attachment 158295 [details] poudriere build output
as far as I'm aware, all future development is going into rancid3. The ipaddrsort() patch has been submitted upstream and it's been accepted for rancid3. The other two patches will be submitted when we migrate to rancid3.
Understood nick, thank you :)
BTW, rancid-2.3.8.tar.gz DISTFILE is 404. ftp://ftp.shrubbery.net/pub/rancid/rancid-2.3.8.tar.gz: File unavailable (e.g., file not found, no access) I'll continue with this change, but an update to this should be forthcoming, and/or mirrors of the current distfiles created and hosted somewhere.
I also noticed the following while build testing: If you would like to set up Rancid to be browseable from Web, you need to install devel/cvsweb or devel/viewvc. Might be worth considering some options for these (not OPTIONS_DEFAULT)
A commit references this bug: Author: koobs Date: Fri Jul 3 17:43:56 UTC 2015 New revision: 391264 URL: https://svnweb.freebsd.org/changeset/ports/391264 Log: net-mgmt/rancid: Fix IPv6 prefix-lists, ASR9001 output and foundry slowness Back-port a patch from 3.2 to 2.3.8 to make ipv6 prefix-lists sort properly, which is broken in perl >=5.18 due to hash randomisation changes Fix ASR9001 XR, which updates 3 hard disk files on a regular basis (uptime_cont, temp_cont, volt_cont), which causes excessive output noise. Change timing parameters for foundry networks equipment (brocade) so that it doesn't take eternity to make configuration changes on multiple switches. PR: 200733 Submitted by: <nick foobar org> Approved by: Janos Mohacsi <jmohacsi bsd hu> (maintainer) Changes: head/net-mgmt/rancid/Makefile head/net-mgmt/rancid/files/patch-bin__flogin.in head/net-mgmt/rancid/files/patch-bin__rancid.in head/net-mgmt/rancid/files/patch-bin__xrrancid.in
Committed, thank you Nick
Created attachment 158406 [details] fix for Socket AF_INET6 oops, the original patch left out support for AF_INET6. This patch should be applied on top of what's there now.
New patch needs to be applied (#12)
Pending maintainer approval. In future, additional changes should go into a new issue. If an issue is related to a previous change, you may use the See Also: field to reference it. We also have a regression keyword for these cases that can be used
approved.
A commit references this bug: Author: koobs Date: Wed Aug 5 13:41:29 UTC 2015 New revision: 393588 URL: https://svnweb.freebsd.org/changeset/ports/393588 Log: net-mgmt/rancid: Add AF_INET6 support Add AF_INET6 support that was left out of the previous update. PR: 200733 Submitted by: Nick <nick foobar org> Approved by: Janos Mohacsi <jmohacsi bsd hu> (maintainer) Changes: head/net-mgmt/rancid/Makefile head/net-mgmt/rancid/files/patch-bin__rancid.in