Bug 200827 - [exp-run] [patch] sys/queue.h changes
Summary: [exp-run] [patch] sys/queue.h changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hans Petter Selasky
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-12 21:48 UTC by Hans Petter Selasky
Modified: 2015-10-08 08:07 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer 2015-06-12 21:48:21 UTC
Apply patch in:

https://reviews.freebsd.org/D2745

to FreeBSD-11-current. Affects header files in /usr/include/sys

Report broken packages after patch to kernel.

--HPS
Comment 1 Antoine Brodin freebsd_committer 2015-06-17 19:00:36 UTC
Take for exp-run
Comment 2 Antoine Brodin freebsd_committer 2015-06-19 09:07:11 UTC
Exp-run results on head amd64:

http://package18.nyi.freebsd.org/jail.html?mastername=headamd64D2745-default

15 new failures (and 24 more ports skipped):

+ {"origin"=>"audio/audex", "pkgname"=>"audex-0.79", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"audio/kio-audiocd", "pkgname"=>"kio-audiocd-4.14.3", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"audio/soundkonverter", "pkgname"=>"soundkonverter-2.1.2", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"benchmarks/polygraph", "pkgname"=>"polygraph-4.3.2_1", "phase"=>"build", "errortype"=>"???"}
+ {"origin"=>"emulators/virtualbox-ose", "pkgname"=>"virtualbox-ose-4.3.28_1", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"multimedia/kodi", "pkgname"=>"kodi-14.2_2", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"multimedia/plexhometheater", "pkgname"=>"plexhometheater-1.4.1_1", "phase"=>"build", "errortype"=>"???"}
+ {"origin"=>"net-im/imspector", "pkgname"=>"imspector-20111108_2", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"net/xorp", "pkgname"=>"xorp-1.8.5", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"sysutils/dvd+rw-tools", "pkgname"=>"dvd+rw-tools-7.1_1", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"sysutils/geomWatch", "pkgname"=>"geomWatch-1.3.0_2", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"sysutils/pflogx", "pkgname"=>"pflogx-0.86", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"sysutils/qpxtool", "pkgname"=>"qpxtool-0.7.2_1", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"sysutils/smartmontools", "pkgname"=>"smartmontools-6.4", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"www/chromium", "pkgname"=>"chromium-43.0.2357.125", "phase"=>"build", "errortype"=>"clang"}

Failure logs:

http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/audex-0.79.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/kio-audiocd-4.14.3.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/soundkonverter-2.1.2.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/polygraph-4.3.2_1.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/virtualbox-ose-4.3.28_1.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/kodi-14.2_2.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/plexhometheater-1.4.1_1.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/imspector-20111108_2.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/xorp-1.8.5.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/dvd+rw-tools-7.1_1.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/geomWatch-1.3.0_2.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/pflogx-0.86.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/qpxtool-0.7.2_1.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/smartmontools-6.4.log
http://package18.nyi.freebsd.org/data/headamd64D2745-default/2015-06-18_23h07m40s/logs/errors/chromium-43.0.2357.125.log
Comment 3 Hans Petter Selasky freebsd_committer 2015-06-19 10:37:50 UTC
Can you re-run with updated patch in:

https://reviews.freebsd.org/D2745

--HPS
Comment 4 Antoine Brodin freebsd_committer 2015-06-20 20:37:30 UTC
Exp-run results with new version of the patch:

http://package18.nyi.freebsd.org/build.html?mastername=headamd64D2745-default&build=2015-06-20_15h26m54s

0 new failure
Comment 5 Antoine Brodin freebsd_committer 2015-06-21 10:35:45 UTC
grr,  take again,  the patch wasn't tested correctly has it wasn't relative to src tree...
Comment 7 commit-hook freebsd_committer 2015-06-28 21:06:56 UTC
A commit references this bug:

Author: hselasky
Date: Sun Jun 28 21:06:46 UTC 2015
New revision: 284915
URL: https://svnweb.freebsd.org/changeset/base/284915

Log:
  Make the system queue header file fully usable within C++ programs by
  adding macros to define class lists.

  This change is backwards compatible for all use within C and C++
  programs. Only C++ programs will have added support to use the queue
  macros within classes. Previously the queue macros could only be used
  within structures.

  The queue.3 manual page has been updated to describe the new
  functionality and some alphabetic sorting has been done while
  at it.

  Differential Revision:	https://reviews.freebsd.org/D2745
  PR:			200827 (exp-run)
  MFC after:		2 weeks

Changes:
  head/share/man/man3/Makefile
  head/share/man/man3/queue.3
  head/sys/sys/queue.h
Comment 8 commit-hook freebsd_committer 2015-10-08 07:51:07 UTC
A commit references this bug:

Author: hselasky
Date: Thu Oct  8 07:50:51 UTC 2015
New revision: 289018
URL: https://svnweb.freebsd.org/changeset/base/289018

Log:
  MFC r284915:
  Make the system queue header file fully usable within C++ programs by
  adding macros to define class lists.

  This change is backwards compatible for all use within C and C++
  programs. Only C++ programs will have added support to use the queue
  macros within classes. Previously the queue macros could only be used
  within structures.

  The queue.3 manual page has been updated to describe the new
  functionality and some alphabetic sorting has been done while
  at it.

  Differential Revision:	https://reviews.freebsd.org/D2745
  PR:			200827 (exp-run)

Changes:
_U  stable/10/
  stable/10/share/man/man3/Makefile
  stable/10/share/man/man3/queue.3
  stable/10/sys/sys/queue.h
Comment 9 commit-hook freebsd_committer 2015-10-08 08:07:09 UTC
A commit references this bug:

Author: hselasky
Date: Thu Oct  8 08:06:24 UTC 2015
New revision: 289019
URL: https://svnweb.freebsd.org/changeset/base/289019

Log:
  MFC r284915:
  Make the system queue header file fully usable within C++ programs by
  adding macros to define class lists.

  This change is backwards compatible for all use within C and C++
  programs. Only C++ programs will have added support to use the queue
  macros within classes. Previously the queue macros could only be used
  within structures.

  The queue.3 manual page has been updated to describe the new
  functionality and some alphabetic sorting has been done while
  at it.

  Differential Revision:	https://reviews.freebsd.org/D2745
  PR:			200827 (exp-run)

Changes:
_U  stable/9/share/
_U  stable/9/share/man/
_U  stable/9/share/man/man3/
  stable/9/share/man/man3/Makefile
  stable/9/share/man/man3/queue.3
_U  stable/9/sys/
_U  stable/9/sys/sys/
  stable/9/sys/sys/queue.h