Bug 200829 - [PATCH] devel/avr-gdb: Add PYTHON option to make dependency explicit
Summary: [PATCH] devel/avr-gdb: Add PYTHON option to make dependency explicit
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joerg Wunsch
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-12 22:48 UTC by Craig Leres
Modified: 2016-09-17 23:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (joerg)

Attachments
Patchset for devel/avr-gdb (794 bytes, text/plain)
2015-06-12 22:48 UTC, Craig Leres 		no flags Details
poudriere build log (324.30 KB, text/plain)
2015-06-12 22:51 UTC, Craig Leres 		no flags Details
poudriere build log (9.3-RELEASE) (324.30 KB, text/plain)
2015-06-12 22:52 UTC, Craig Leres 		no flags Details
poudriere build log (10.1-RELEASE) (622.16 KB, text/plain)
2015-06-12 22:52 UTC, Craig Leres 		no flags Details
patch (972 bytes, patch)
2015-12-21 02:47 UTC, Craig Leres 		no flags Details | Diff
poudriere build log (10.1-RELEASE) (621.28 KB, text/plain)
2015-12-21 02:49 UTC, Craig Leres 		no flags Details
revised patch (855 bytes, patch)
2016-09-17 23:39 UTC, Craig Leres 		no flags Details | Diff
poudriere build log (10.3-RELEASE) (625.24 KB, text/plain)
2016-09-17 23:40 UTC, Craig Leres 		no flags Details
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2015-06-12 22:48:38 UTC 
Created attachment 157692 [details]
Patchset for devel/avr-gdb

The avr-gdb package enables python support if it finds a python binary at configure time. This means an avr-gdb package built on a system with python will not run on a system that doesn't have python.

Make the dependency on python explicit by adding an option for it.
Comment 1 Craig Leres freebsd_committer 2015-06-12 22:51:49 UTC 
Created attachment 157693 [details]
poudriere build log
Comment 2 Craig Leres freebsd_committer 2015-06-12 22:52:22 UTC 
Created attachment 157694 [details]
poudriere build log (9.3-RELEASE)
Comment 3 Craig Leres freebsd_committer 2015-06-12 22:52:45 UTC 
Created attachment 157695 [details]
poudriere build log (10.1-RELEASE)
Comment 4 Craig Leres freebsd_committer 2015-12-21 02:46:16 UTC 
I was in the process of filing a new PR to fix this problem when I noticed that I already did so back in June.

Attached is an updated patch:

    - Make the dependency on python explicit by adding an option for it

    - Fix some portlint complaints
Comment 5 Craig Leres freebsd_committer 2015-12-21 02:47:23 UTC 
Created attachment 164440 [details]
patch
Comment 6 Craig Leres freebsd_committer 2015-12-21 02:49:03 UTC 
Created attachment 164441 [details]
poudriere build log (10.1-RELEASE)
Comment 7 Craig Leres freebsd_committer 2016-09-17 23:39:43 UTC 
Created attachment 174894 [details]
revised patch

This is still an issue.

Here's an updated patch that uses newer OPTIONS features. It also quiets some portlint complaints and eliminates pkg-plist (which should be removed).
Comment 8 Craig Leres freebsd_committer 2016-09-17 23:40:29 UTC 
Created attachment 174895 [details]
poudriere build log (10.3-RELEASE)