Bug 200923 - lang/guile: fix build with NLS disabled
Summary: lang/guile: fix build with NLS disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-16 23:06 UTC by Dmitry Marakasov
Modified: 2015-06-18 11:38 UTC (History)
0 users

See Also:
bofh: maintainer-feedback+


Attachments
Patch (531 bytes, patch)
2015-06-16 23:06 UTC, Dmitry Marakasov
no flags Details | Diff
Failure log (25.09 KB, text/plain)
2015-06-16 23:07 UTC, Dmitry Marakasov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:06:32 UTC
Created attachment 157816 [details]
Patch

Guile build requires gettext-tools to be present even if NLS disabled, so add corresponding dependency.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:07:07 UTC
Created attachment 157817 [details]
Failure log
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2015-06-17 08:33:02 UTC
Poudriere is building with the patch however one small query. As LGPL21 is in the LICENSE framework is there any requirements for LICENSE_FILE?
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-17 16:07:09 UTC
(In reply to Muhammad Moinur Rahman from comment #2)
> Poudriere is building with the patch however one small query. As LGPL21 is
> in the LICENSE framework is there any requirements for LICENSE_FILE?

Yes, it was decided that LICENSE_FILE is mandatory even for known licenses. Unfortunately it doesn't seem to be documented, but here's irc (EFNet #bsdports, May 15 2014) log excerpt:

00:19 <@mat__> what should be done is say LICENSE=GPLv2, and LICENSE_FILE=${WRKSRC}/... so that the actual license text is there
00:19 < AMDmi3> I though we don't specify LICENSE_FILE for known licenses
00:20 <@mat__> AMDmi3, it doesn't *do* anything, the license is GPLv2, and the text of the license says that it is this one or later
00:20 <@mat__> and that's a mistake, we should always specify LICENSE_FILE, because everybody edits it to set name, year, and things like that
00:21 <@mat__> so the sample we have and put in the package is not the actual license
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-06-18 11:37:50 UTC
A commit references this bug:

Author: bofh
Date: Thu Jun 18 11:36:51 UTC 2015
New revision: 390026
URL: https://svnweb.freebsd.org/changeset/ports/390026

Log:
  lang/guile: Fix build with NLS disabled

  - Add LICENSE_FILE

  PR:		200923
  Submitted by:	amdmi3@FreeBSD.org

Changes:
  head/lang/guile/Makefile
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2015-06-18 11:38:19 UTC
Thanks.