Bug 200955 - [patch] Update net-mgmt/victorops-nagios to 1.3.16
Summary: [patch] Update net-mgmt/victorops-nagios to 1.3.16
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-18 15:25 UTC by Brad Davis
Modified: 2016-01-18 10:48 UTC (History)
1 user (show)

See Also:

Attachments
patch (10.33 KB, patch)
2015-06-18 15:25 UTC, Brad Davis 		no flags Details | Diff
poudriere build log (16.24 KB, text/plain)
2015-06-18 15:33 UTC, Brad Davis 		no flags Details
Updated patch to bring victorops-nagios to version 1.3.16. (15.54 KB, patch)
2015-06-23 19:04 UTC, Douglas K. Rand 		no flags Details | Diff
Fixed patch with @sample in pkg-plist (15.66 KB, patch)
2015-06-23 19:14 UTC, Douglas K. Rand 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2015-06-18 15:25:42 UTC 
Created attachment 157863 [details]
patch
Comment 1 Brad Davis freebsd_committer freebsd_triage 2015-06-18 15:26:25 UTC 
Not sure why this was assigned to portmgr..
Comment 2 Brad Davis freebsd_committer freebsd_triage 2015-06-18 15:33:29 UTC 
Created attachment 157864 [details]
poudriere build log
Comment 3 Brad Davis freebsd_committer freebsd_triage 2015-06-18 15:34:22 UTC 
Note that I do not have a victorops account, so I just forward ported the existing patches and simplified them a little.
Comment 4 Douglas K. Rand 2015-06-23 19:04:28 UTC 
Created attachment 158023 [details]
Updated patch to bring victorops-nagios to version 1.3.16.

I took Brad Davis' patch and worked on it a bit.

This patch leaves some empty patch-* in the files directory that should be removed.

Needed to add coreutils dependency to get gtimeout added, and added the missing ca_root_nss dependency.
Comment 5 Brad Davis freebsd_committer freebsd_triage 2015-06-23 19:07:53 UTC 
What about the @sample parts of the plist?
Comment 6 Douglas K. Rand 2015-06-23 19:14:07 UTC 
Created attachment 158024 [details]
Fixed patch with @sample in pkg-plist

Oops, forgot the @sample decorations in the pkg-plist.

Thanks for the reminder Brad.
Comment 7 Douglas K. Rand 2015-06-23 19:15:05 UTC 
Brad, thanks for the work on this. I made some changes to your patch:

* Added coreutils to RUN_DEPENDS so that I could get gtimeout. And tweaked the patch-check_victorops_cmds patch to use it.

* I kept the -a option to psin patch-check_victorops_forwarder to make sure we looked at all processes

* I updated the qpage-patch to VictroOps new style.

Sorry that vacation intruded on getting on to this quickly.

The attached patch orphans some empty patch files that should be removed:

* patch-do_victorops_heartbeat
* patch-enqueue_alert
* patch-forward_alerts
* patch-support_collect.sh
* patch-victorops.cron
Comment 8 Brad Davis freebsd_committer freebsd_triage 2015-06-23 21:43:09 UTC 
Looks good, with your approval I will test and commit.
Comment 9 Douglas K. Rand 2015-06-24 02:41:46 UTC 
Sorry for the delay Brad. (Email response seems delayed somewhere.) 

Go right ahead.  Thanks.
Comment 10 Douglas K. Rand 2016-01-17 23:29:39 UTC 
Superseded by Bug 206350.
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-18 10:48:32 UTC 
Not sure why this was Assigned to a non-committer (though it turned out swimmingly!)