Bug 200987 - sys/dev/ixgbe/ixgbe.c:1058: bad if statement ?
Summary: sys/dev/ixgbe/ixgbe.c:1058: bad if statement ?
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: IntelNetworking
Depends on:
Blocks:
 
Reported: 2015-06-20 08:37 UTC by David Binderman
Modified: 2015-06-30 16:32 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-06-20 08:37:58 UTC 
sys/dev/ixgbe/ixgbe.c:1058]: (warning)
 Logical disjunction always evaluates to true: EXPR != 160 || EXPR != 162.

   if ((i2c.dev_addr != 0xA0) || (i2c.dev_addr != 0xA2)){

Maybe

   if ((i2c.dev_addr != 0xA0) && (i2c.dev_addr != 0xA2)){
Comment 1 Sean Bruno freebsd_committer 2015-06-30 16:32:16 UTC 
When the ixgbe driver was split and refactored, this line (now in if_ix.c) was changed to:

                if (i2c.dev_addr != 0xA0 && i2c.dev_addr != 0xA2) {