Bug 200989 - usr.sbin/ppp/mppe.c:171: bad if statement ?
Summary: usr.sbin/ppp/mppe.c:171: bad if statement ?
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-20 08:46 UTC by David Binderman
Modified: 2019-02-07 13:58 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-06-20 08:46:20 UTC 
usr.sbin/ppp/mppe.c:171]: (warning) Logical conjunction always evaluates to false: EXPR < 33 && EXPR > 250.

  if (*proto < 0x21 && *proto > 0xFA) {

Maybe

  if (*proto < 0x21 || *proto > 0xFA) {
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-02-07 13:58:11 UTC 
Fixed in base r256574.