Bug 201138 - textproc/pugixml: update to 1.6
Summary: textproc/pugixml: update to 1.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-26 23:12 UTC by Dmitry Marakasov
Modified: 2015-07-27 16:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ybungalobill)


Attachments
Patch (3.01 KB, patch)
2015-06-26 23:12 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-26 23:12:17 UTC
Created attachment 158086 [details]
Patch

- Update to 1.6
Comment 1 Yakov Galka 2015-07-24 16:38:01 UTC
Hey,

Thank you for preparing the patch.

I've applied the patch, built and installed it on a clean system, and tested it with some of my code using the library on another. Everything seems OK except that the patch references a non-existing `patch-scripts_CMakeLists.txt` file (one underscore) which I had to correct manually to `patch-scripts__CMakeLists.txt` (two underscores). Not sure how did it happen.

I am not a committer. Can you commit the changes or I shall contact somebody else?
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-27 16:56:32 UTC
> Everything seems OK except that the patch references a non-existing `patch-scripts_CMakeLists.txt` file (one underscore) which I had to correct manually to `patch-scripts__CMakeLists.txt` (two underscores). Not sure how did it happen.

That's probably because file was renamed (patch-scripts__CMakeLists.txt -> patch-scripts_CMakeLists.txt) according to our patch naming scheme (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html).

> I am not a committer. Can you commit the changes

Sure, only your approval was required. Thank you!
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-07-27 16:57:17 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Jul 27 16:56:41 UTC 2015
New revision: 392991
URL: https://svnweb.freebsd.org/changeset/ports/392991

Log:
  - Update to 1.6

  PR:		201138
  Submitted by:	amdmi3
  Approved by:	ybungalobill@gmail.com (maintainer)

Changes:
  head/textproc/pugixml/Makefile
  head/textproc/pugixml/distinfo
  head/textproc/pugixml/files/patch-scripts_CMakeLists.txt
  head/textproc/pugixml/files/patch-scripts__CMakeLists.txt
  head/textproc/pugixml/pkg-descr
  head/textproc/pugixml/pkg-plist