Bug 201162 - multimedia/spook: [patch] fix V4L support & take maintainship
Summary: multimedia/spook: [patch] fix V4L support & take maintainship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-28 09:30 UTC by Michael Zhilin
Modified: 2015-06-28 11:18 UTC (History)
1 user (show)

See Also:

Attachments
SVN diff (4.13 KB, patch)
2015-06-28 09:30 UTC, Michael Zhilin 		no flags Details | Diff
portlint output (12 bytes, text/plain)
2015-06-28 09:30 UTC, Michael Zhilin 		no flags Details
poudriere testport - JPEG, no V4L, no MPEG (65.88 KB, text/plain)
2015-06-28 09:33 UTC, Michael Zhilin 		no flags Details
poudriere testport - default - MPEG, V4L, no JPEG (69.00 KB, text/plain)
2015-06-28 09:34 UTC, Michael Zhilin 		no flags Details
poudriere testport - all - MPEG, V4L, JPEG, DOCS (69.53 KB, text/plain)
2015-06-28 09:38 UTC, Michael Zhilin 		no flags Details
poudriere testport - DOCS - MPEG, V4L, DOCS, no JPEG (68.99 KB, text/plain)
2015-06-28 09:39 UTC, Michael Zhilin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:30:17 UTC 
Created attachment 158114 [details]
SVN diff

Hi,

Please review & commit patch for multimedia/spook. It's old port without maintainer and it doesn't work with V4L webcam on latest FreeBSD versions (9+). Root cause is that Video4BSD provides only V4L2 support, and if client uses V4L, it should use libv4l. So patch allows to use libv4l, so it fixes issue. 

It works for me. Portlint & poudriere testport are attached to ticket.

Also port has no maintainer now. I'll be happy to take maintainship. :)

It's worth to note that I've tested it with Logitech C310 webcam and found significant CPU consumption in JPEG case (found thanks to dtrace). That's why MPEG4 is only default case and JPEG casting is disabled by default.

Best regards,
Michael
Comment 1 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:30:58 UTC 
Created attachment 158115 [details]
portlint output
Comment 2 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:33:13 UTC 
Created attachment 158116 [details]
poudriere testport - JPEG, no V4L, no MPEG
Comment 3 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:34:27 UTC 
Created attachment 158117 [details]
poudriere testport - default - MPEG, V4L, no JPEG
Comment 4 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:38:22 UTC 
Created attachment 158118 [details]
poudriere testport - all - MPEG, V4L, JPEG, DOCS
Comment 5 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 09:39:22 UTC 
Created attachment 158119 [details]
poudriere testport - DOCS - MPEG, V4L, DOCS, no JPEG
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-28 10:48:11 UTC 
A commit references this bug:

Author: wen
Date: Sun Jun 28 10:47:14 UTC 2015
New revision: 390778
URL: https://svnweb.freebsd.org/changeset/ports/390778

Log:
  - Fix V4L support
  - Add LICENSE
  - Pass maintainership to submitter

  PR:		201162
  Submitted by:	mizhka@gmail.com

Changes:
  head/multimedia/spook/Makefile
  head/multimedia/spook/files/patch-bswap.h
  head/multimedia/spook/files/patch-configure.ac
  head/multimedia/spook/files/patch-input-oss.c
  head/multimedia/spook/files/patch-md5.c
  head/multimedia/spook/files/patch-tcp.c
Comment 7 Michael Zhilin freebsd_committer freebsd_triage 2015-06-28 11:18:27 UTC 
Thank you!