Bug 201202 - [patch] audio/festival: add missing @dirs to plist
Summary: [patch] audio/festival: add missing @dirs to plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alberto Villa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-29 15:41 UTC by Alberto Villa
Modified: 2015-07-01 14:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mi)


Attachments
Fix to the issue (688 bytes, patch)
2015-06-29 15:41 UTC, Alberto Villa
no flags Details | Diff
Patch removing directories (572 bytes, patch)
2015-07-01 09:34 UTC, Alberto Villa
no flags Details | Diff
Fix to 'stage' (605 bytes, patch)
2015-07-01 10:17 UTC, Alberto Villa
mi: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Villa freebsd_committer 2015-06-29 15:41:47 UTC
Created attachment 158163 [details]
Fix to the issue

ports r367104 removed some '@exec mkdir' without adding respective '@dir'.
Comment 1 Mikhail T. 2015-06-29 22:17:57 UTC
I do not believe, the PORTREVISION bump is warranted -- people, who already have the port installed, will NOT benefit by rebuilding it.

As for the empty directories, I wonder, if they should not simply be removed instead... Whatever additional package may populate them later can create them -- and clean them up upon installation...
Comment 2 Alberto Villa freebsd_committer 2015-07-01 09:34:54 UTC
Created attachment 158211 [details]
Patch removing directories

A PORTREVISION bump would have been necessary as the package would have started installing three empty directories.

Anyway, I've seen those directories were there only to create a hierarchy for voices and dictionaries. I agree this isn't needed anymore with pkg(8). I've attached a new patch which simply avoids creating them in 'do-install'.
Comment 3 Alberto Villa freebsd_committer 2015-07-01 10:17:28 UTC
Created attachment 158215 [details]
Fix to 'stage'

Sorry, wrong patch. Here's the new one.
Comment 4 commit-hook freebsd_committer 2015-07-01 14:21:17 UTC
A commit references this bug:

Author: mi
Date: Wed Jul  1 14:21:01 UTC 2015
New revision: 391068
URL: https://svnweb.freebsd.org/changeset/ports/391068

Log:
  Fix build on arm (v6). Do not create empty directories.

  PR:		200287, 201202
  Submitted by:	Mikael Urankar, avilla

Changes:
  head/audio/festival/Makefile