Bug 201283 - sys/dev/bxe/bxe_elink.c:14583: bad expression
Summary: sys/dev/bxe/bxe_elink.c:14583: bad expression
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: David C Somayajulu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-02 15:56 UTC by David Binderman
Modified: 2018-03-08 15:49 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-07-02 15:56:03 UTC 
sys/dev/bxe/bxe_elink.c:14583]: (style) Expression '(X & 0xe0
) == 0x2' is always false.

      ((next_page & 0xe0) == 0x2))));
Comment 1 Wentao Wang 2018-03-08 05:37:14 UTC 
Has been fixed in change cd53b03d2ca116be4d88572bd5c1f2602f71fab0 		25-Feb-2016 by davidcs <davidcs@FreeBSD.org>

to 
    ((next_page & 0xe0) == 0x20))));
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2018-03-08 15:49:25 UTC 
Fixed in r296071 and MFCed to stable/10 and 11.