Bug 201294 - Mk/bsd.gecko.mk: PowerPC no longer needs the __STDC_CONSTANT_MACROS macro defined for gecko
Summary: Mk/bsd.gecko.mk: PowerPC no longer needs the __STDC_CONSTANT_MACROS macro def...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-07-02 21:34 UTC by Justin Hibbits
Modified: 2015-07-24 02:56 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (gecko)

Attachments
Patch to remove __STDC_CONSTANT_MACROS from gecko CFLAGS (347 bytes, patch)
2015-07-04 01:59 UTC, Justin Hibbits 		no flags Details | Diff
Successful poudriere build of firefox (207.89 KB, application/x-gzip)
2015-07-04 02:03 UTC, Justin Hibbits 		no flags Details
Failed poudriere build of firefox (124.97 KB, application/x-gzip)
2015-07-04 02:03 UTC, Justin Hibbits 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer freebsd_triage 2015-07-02 21:34:19 UTC 
Firefox 38 fails to build with __STDC_CONSTANT_MACROS defined on powerpc, as it gets defined both at the command line and in the mozconfig.h header, which the compiler balks at.  Removing this (line 451 of Mk/bsd.gecko.mk) gets it building.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-07-02 22:27:27 UTC 
Bah, fix mispaste.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-03 06:55:33 UTC 
Justin, could you attach:

 * A patch against ports head for the requested change
 * poudriere testport output for a successful build on PPC
Comment 3 Justin Hibbits freebsd_committer freebsd_triage 2015-07-04 01:59:43 UTC 
Created attachment 158316 [details]
Patch to remove __STDC_CONSTANT_MACROS from gecko CFLAGS
Comment 4 Justin Hibbits freebsd_committer freebsd_triage 2015-07-04 02:03:12 UTC 
Created attachment 158317 [details]
Successful poudriere build of firefox
Comment 5 Justin Hibbits freebsd_committer freebsd_triage 2015-07-04 02:03:39 UTC 
Created attachment 158318 [details]
Failed poudriere build of firefox
Comment 6 Justin Hibbits freebsd_committer freebsd_triage 2015-07-04 02:05:42 UTC 
I've uploaded logs from a poudriere bulk run, which I think should be comparable to a testport run, from my experience.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-07-16 11:36:17 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Jul 16 11:36:13 UTC 2015
New revision: 392290
URL: https://svnweb.freebsd.org/changeset/ports/392290

Log:
  bsd.gecko.mk: PowerPC no longer needs the __STDC_CONSTANT_MACROS in CFLAGS

  sys/cdefs.h after base r227475 always defines __STDC_CONSTANT_MACROS
  for C++11 while Firefox enforces C++11 since 25.0 and also defines
  __STDC_CONSTANT_MACROS via mozilla-config.h since 26.0.

  PR:		201294
  Submitted by:	jhibbits
  MFH:		2015Q3 (trivial, not on pkg-fallout)

Changes:
  head/Mk/bsd.gecko.mk
Comment 8 Jan Beich freebsd_committer freebsd_triage 2015-07-16 11:39:07 UTC 
Thanks. Committed.
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-07-24 02:56:30 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Jul 24 02:55:54 UTC 2015
New revision: 392766
URL: https://svnweb.freebsd.org/changeset/ports/392766

Log:
  MFH: r392290

  bsd.gecko.mk: PowerPC no longer needs the __STDC_CONSTANT_MACROS in CFLAGS

  sys/cdefs.h after base r227475 always defines __STDC_CONSTANT_MACROS
  for C++11 while Firefox enforces C++11 since 25.0 and also defines
  __STDC_CONSTANT_MACROS via mozilla-config.h since 26.0.

  As Firefox 38.0 enables -pedantic-errors this breaks build. So, remove
  the dup to unbreak build on powerpc and powerpc64.

  PR:		201294
  Submitted by:	jhibbits
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/Mk/bsd.gecko.mk