Bug 201383 - [NEW PORT] net/py-IPy: Handling of IPv4 and IPv6 addresses in Python
Summary: [NEW PORT] net/py-IPy: Handling of IPv4 and IPv6 addresses in Python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: feature, needs-patch, patch
Depends on:
Blocks:
 
Reported: 2015-07-07 00:50 UTC by Yuri Victorovich
Modified: 2015-07-09 23:18 UTC (History)
3 users (show)

See Also:

Attachments
shar archive (1.72 KB, application/shar)
2015-07-07 00:50 UTC, Yuri Victorovich 		no flags Details
shar archive (1.72 KB, text/plain)
2015-07-07 00:52 UTC, Yuri Victorovich 		no flags Details
poudriere log (12.12 KB, text/plain)
2015-07-07 00:53 UTC, Yuri Victorovich 		no flags Details
shar archive (1.74 KB, application/shar)
2015-07-07 00:55 UTC, Yuri Victorovich 		no flags Details
Updated shar (1.60 KB, application/shar)
2015-07-07 04:58 UTC, Yuri Victorovich 		no flags Details
Updated shar (1.63 KB, text/plain)
2015-07-07 08:26 UTC, Yuri Victorovich 		no flags Details
Updated shar (1.50 KB, text/plain)
2015-07-07 19:17 UTC, Yuri Victorovich 		no flags Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 00:50:21 UTC 
Created attachment 158439 [details]
shar archive
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 00:52:46 UTC 
Created attachment 158440 [details]
shar archive
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 00:53:47 UTC 
Created attachment 158441 [details]
poudriere log
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 00:55:54 UTC 
Created attachment 158442 [details]
shar archive

Added NOARCH
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 04:25:48 UTC 
Thanks Yuri. On initial review:

* Lowercase PORTNAME
* Use DISTNAME instead of GH_PROJECT/GH_TAGNAME
* Sort USE_PYTHON values
* LICENSE appears to be BSD (3CLAUSE) as per setup.py and COPYING file
* Remove trailing slash from pkg-descr: WWW url
* I would probably remove "Python class and " from COMMENT

By the way, our reviews system (Phabricator) is now configured to accept outside contributor accounts. I highly recommend creating an account there to obtain future reviews for your contributions
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 04:39:19 UTC 
> * Lowercase PORTNAME

It is branded as IPy, making it ipy will decrease its recognizability
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 04:43:24 UTC 
> By the way, our reviews system (Phabricator) is now configured to accept outside contributor accounts. I highly recommend creating an account there to obtain future reviews for your contributions

It will likely make such submission much more work. Need to submit at least twice then.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 04:49:05 UTC 
> * LICENSE appears to be BSD (3CLAUSE) as per setup.py and COPYING file

No, COPYING file doesn't say tis is BSD license. I asked upstream to clarify:
https://github.com/autocracy/python-ipy/issues/39
Until then we should just use it as-is.
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 04:58:37 UTC 
Created attachment 158465 [details]
Updated shar

> * Use DISTNAME instead of GH_PROJECT/GH_TAGNAME

DISTNAME evaluates to different thing for GH-based project. So I left this one.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 04:59:30 UTC 
(In reply to yuri from comment #7)

See: https://github.com/autocracy/python-ipy/blob/master/setup.py#L67
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:26:18 UTC 
Created attachment 158479 [details]
Updated shar
Comment 11 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 19:17:40 UTC 
Created attachment 158514 [details]
Updated shar
Comment 12 Wen Heping freebsd_committer freebsd_triage 2015-07-08 13:02:51 UTC 
Hi:

   There is net-mgmt/py-ipy in portstree :)

wen
Comment 13 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-08 18:44:33 UTC 
Ah, I see, thanks. Because I searched for IPy, but ity is spelled in lowercase, and PYPI also seems to be case insensitive for some reason.

Wen, could you please update net-mgmt/py-ipy to the latest version please?
Comment 14 Wen Heping freebsd_committer freebsd_triage 2015-07-09 00:51:16 UTC 
I updated it to 0.83 and reset maintainer to ports@.
Yuri, please feel free to take maintainership of it now.

wen
Comment 15 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-09 23:18:51 UTC 
Thanks Wen!

I am not particularly into this package though, I was combing through the dependencies of another, larger package that I am creating and came across py-IPy.

Yuri