Bug 201384 - [NEW PORT] dns/py-dnschain: Python library for looking up blockchain data via DNSChain
Summary: [NEW PORT] dns/py-dnschain: Python library for looking up blockchain data via...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-07-07 01:07 UTC by Yuri Victorovich
Modified: 2015-12-04 15:06 UTC (History)
3 users (show)

See Also:
yuri: maintainer-feedback+

Attachments
shar archive (1.63 KB, application/shar)
2015-07-07 01:07 UTC, Yuri Victorovich 		no flags Details
poudriere log (14.32 KB, text/plain)
2015-07-07 01:08 UTC, Yuri Victorovich 		no flags Details
Updated shar (1.47 KB, text/plain)
2015-07-07 17:41 UTC, Yuri Victorovich 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 01:07:55 UTC 
Created attachment 158443 [details]
shar archive
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 01:08:42 UTC 
Created attachment 158444 [details]
poudriere log
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 04:29:58 UTC 
Review:

 * Use DISTNAME to deprecate GH_PROJECT
 * Sort USE_PYTHON values
 * COMMENT, remove leading "Python "
 * Strip trailing slash from pkg-descr WWW: URL
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 05:37:26 UTC 
Additionally:

 * Use CHEESESHOP unless Github has tests/testsuite
 * PORTVERSION is 0.1.0 See: https://pypi.python.org/pypi/dnschain/0.1.0
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:20:06 UTC 
Kubilay,

> * Use CHEESESHOP unless Github has tests/testsuite
> * PORTVERSION is 0.1.0 See: https://pypi.python.org/pypi/dnschain/0.1.0

But Github is the real upstream for py-dnschain. This OkTurtles guy is the original author. He forgot to set version on python project, so CHEESESHOP just defaulted to 0.1.0.

I suggest we should keep Github since it isn't the fork in this case.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 08:39:16 UTC 
(In reply to yuri from comment #4)

The issue not strictly about where upstream is, the issues are that:

 * Users and pip default to using packages provided by PyPi if sdists exist there
 * PyPi is the canonical/official package library system for Python in general
 * Other packages that may depend on another python package use PyPi versioning in {*_requires) fields.

Regarding distribution files, once naming/versioning issues are addressed:

We (Python Team) prefer distribution files and describing python ports from CHEESESHOP and PyPi metadata in the absence of a compelling reason to do otherwise (such as the sdist doesnt contain tests/ or test suite files).

A couple of reason for this are:

 * portscout works with CHEESESHOP by default, and has been known not to work for notifying on github version updates. I believe it still doesn't work
 * It encourages upstream authors to understand, correctly and accurately package their software.

The author should ensure that the PyPI entry has up-to-date and correct metadata, especially versioning and naming. If the __version__ data in the sources are incorrect, they need to be fixed. Alternately if the PyPI version is incorrect, *it* should be fixed.

On a related note, X.Y.Z versioning is much easier, so I would encourage you to suggest, and the author to consider standard, simple semantic, versions.

All of the above will ensure the minimization of naming and other conflicts for both the FreeBSD Ports framework, its Python users, and other users of the software.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 17:41:23 UTC 
Created attachment 158510 [details]
Updated shar
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-07 03:50:40 UTC 
Updated QA log required? (log datestamp < shar datestamp)
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2015-08-14 01:52:54 UTC 
QA is passing fine.
This port is ready to be committed.
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-12-04 15:03:42 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Dec  4 15:03:13 UTC 2015
New revision: 402992
URL: https://svnweb.freebsd.org/changeset/ports/402992

Log:
  Python library for looking up blockchain data via DNSChain

  WWW: https://github.com/okTurtles/pydnschain

  PR:		201384
  Submitted by:	yuri@rawbw.com

Changes:
  head/dns/Makefile
  head/dns/py-dnschain/
  head/dns/py-dnschain/Makefile
  head/dns/py-dnschain/distinfo
  head/dns/py-dnschain/pkg-descr