Created attachment 158531 [details]
Fix for arm64
On arm64 png fails as png_init_filter_functions_neon is missing. This appears to be a bug with the cmake config missing arm/arm_init.c and arm/filter_neon_intrinsics.c. The attached patch fixes this for me such that the tests pass.
As both these files check if they should be used it is safe to build them on non-arm platforms.
Were there any problems with this? It would be nice to get this in as it blocks 2610 ports on arm64.
Created attachment 159316 [details]
Use gnu configure instead of cmake
Could you try attached patch?
It switches build system from cmake to gnu configure which seems aware of arm64
(In reply to Antoine Brodin from comment #2)
That patch works for me, with no test failures.
A commit references this bug:
Date: Wed Jul 29 06:07:59 UTC 2015
New revision: 393143
Switch build system from cmake to GNU configure
There are 2 benefits:
- Reduced number of build dependencies (0 now)
- This fixes build on arm64, as configure/Makefile are more updated than
CMakeLists.txt (CMakeLists.txt doesn't know about the arm/arm_init.c
and arm/filter_neon_intrinsics.c files)
Tested by: Andrew Turner (on arm64)