Bug 201598 - audio/mous attempts to use x86 ASM on non-x86 Architectures
Summary: audio/mous attempts to use x86 ASM on non-x86 Architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Sean Bruno
URL: http://chips.ysv.freebsd.org/data/11a...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-15 17:59 UTC by Sean Bruno
Modified: 2015-08-15 03:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (shen.elf)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer 2015-07-15 17:59:23 UTC
I think, that the ASSEMBLY option should be defined for AMD64 and i386 only and not a blanket option.

OPTIONS_DEFAULT_amd64= ASSEMBLY
OPTIONS_DEFAULT_i386= ASSEMBLY
Comment 1 Yanhui Shen 2015-08-06 15:12:45 UTC
(In reply to Sean Bruno from comment #0)
You are right, and thanks for the patch.
Comment 2 Sean Bruno freebsd_committer 2015-08-11 18:02:50 UTC
(In reply to Yanhui Shen from comment #1)
Index: Makefile
===================================================================
--- Makefile	(revision 393956)
+++ Makefile	(working copy)
@@ -18,9 +18,12 @@
 OPTIONS_DEFINE=		ALSA ASSEMBLY FAAC FAAD FLAC LAME AO CUE MAC4DECODER \
 			MACDECODER MPG123 NCURSES OSS QT4 SDK TAGLIB VORBIS \
 			WAVDECODER WAVENCODER WMA
-OPTIONS_DEFAULT=	ASSEMBLY FAAC FAAD FLAC LAME CUE MAC4DECODER \
+OPTIONS_DEFAULT=	FAAC FAAD FLAC LAME CUE MAC4DECODER \
 			MPG123 NCURSES OSS QT4 TAGLIB VORBIS WAVDECODER \
 			WAVENCODER WMA
+OPTIONS_DEFAULT_amd64=	ASSEMBLY
+OPTIONS_DEFAULT_i386=	ASSEMBLY
+
 OPTIONS_SUB=		yes
 
 ALSA_LIB_DEPENDS=	libasound.so:${PORTSDIR}/audio/alsa-lib
Comment 3 commit-hook freebsd_committer 2015-08-14 18:30:59 UTC
A commit references this bug:

Author: sbruno
Date: Fri Aug 14 18:30:55 UTC 2015
New revision: 394246
URL: https://svnweb.freebsd.org/changeset/ports/394246

Log:
  Move ASSEMBLY to an i386/amd64 only OPTION_DEFAULT

  PR:		201598
  Reviewed by:	shen.elf@gmail.com (maintainer)

Changes:
  head/audio/mous/Makefile