Bug 201779 - PORTS_MODULES does not support make reinstallkernel
Summary: PORTS_MODULES does not support make reinstallkernel
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-23 01:11 UTC by rkoberman
Modified: 2018-12-03 01:11 UTC (History)
3 users (show)

See Also:
pl: mfc-stable11?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rkoberman 2015-07-23 01:11:26 UTC 
If a system defines "PORTS_MODULES in /etc/src.conf, doing a a "make reinstallkernel" fails as bsd.port.mk does not define a target for "redeinstall".

===> Ports module emulators/virtualbox-ose-kmod (reinstall)
cd ${PORTSDIR:-/usr/ports}/emulators/virtualbox-ose-kmod; PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/usr/games:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/usr/obj/usr/src/tmp/usr/games:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin  SRC_BASE=/usr/src  OSVERSION=1001519  WRKDIRPREFIX=/usr/obj/usr/src/sys/ make -B redeinstall deinstall reinstall
make[3]: don't know how to make redeinstall. Stop

It looks to me like redeinstall can simply be defined as "reinstall deinstall"

It is not super-significant, but it would be nice if it worked.
Comment 1 pl 2017-03-02 14:09:21 UTC 
I know this is an old report but I get the impression it got overlooked, because right now I'm experiencing the same thing on RELENG 11.0. I have set PORTS_MODULES=net/bwn-firmware-kmod in order to ensure that the BWN firmware gets rebuild the moment I build my kernel. Because I made some specific changes earlier I decided to keep my backup kernel and re-install the new one.

Well...

===> Ports module net/bwn-firmware-kmod (reinstall)
cd ${PORTSDIR:-/usr/ports}/net/bwn-firmware-kmod; env  -u CC  -u CXX  -u CPP  PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin  SRC_BASE=/usr/src  OSVERSION=1100122  WRKDIRPREFIX=/usr/obj/usr/src/sys/FELINER make -B redeinstall deinstall reinstall
make[3]: don't know how to make redeinstall. Stop

make[3]: stopped in /usr/ports/net/bwn-firmware-kmod
*** Error code 2

I think this fully rules out the possibility that it might be the Port which didn't handle a target correctly.
Comment 2 Enji Cooper freebsd_committer freebsd_triage 2017-03-02 22:10:23 UTC 
I'll look at this, since I use this support.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-11-18 20:01:26 UTC 
A commit references this bug:

Author: bdrewery
Date: Sat Nov 18 20:01:02 UTC 2017
New revision: 325970
URL: https://svnweb.freebsd.org/changeset/base/325970

Log:
  Fix 'make -n' for {reinstall,distribute}kernel.

  PR:		201779
  Sponsored by:	Dell

Changes:
  head/Makefile.inc1
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-11-18 20:01:29 UTC 
A commit references this bug:

Author: bdrewery
Date: Sat Nov 18 20:01:06 UTC 2017
New revision: 325971
URL: https://svnweb.freebsd.org/changeset/base/325971

Log:
  Fix PORTS_MODULES+'make reinstallkernel' trying to run bogus 'make redeinstall'.

  Also fix 'make installkernel' running 'make deinstall' twice.

  PR:		201779
  MFC after:	2 weeks
  Sponsored by:	Dell

Changes:
  head/sys/conf/kern.post.mk