Bug 201802 - [NEW PORT] games/hypatia_engine: Hypatia 2D Game Engine
Summary: [NEW PORT] games/hypatia_engine: Hypatia 2D Game Engine
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL: https://reviews.freebsd.org/D2896
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-07-24 01:25 UTC by Lillian Lynn Lemmer
Modified: 2015-08-06 05:21 UTC (History)
3 users (show)

See Also:


Attachments
The shar file for Hypatia 0.2.29 (1.40 KB, text/plain)
2015-07-24 01:38 UTC, Lillian Lynn Lemmer
no flags Details
hypatia.shar (2.05 KB, application/x-shar)
2015-07-24 19:29 UTC, Carlos J Puga Medina
no flags Details
hypatia.shar (7.00 KB, patch)
2015-07-25 21:12 UTC, Carlos J Puga Medina
no flags Details | Diff
hypatia.shar (2.06 KB, application/x-shar)
2015-07-25 21:18 UTC, Carlos J Puga Medina
no flags Details
hypatia_engine.shar (1.76 KB, patch)
2015-08-04 19:23 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lillian Lynn Lemmer 2015-07-24 01:25:33 UTC
I'm the author of Hypatia and this is my first time submitting a package to FreeBSD.

Hypatia 0.2.29: Make 2D action adventure games. For programmers and nonprogrammers alike. Create a games like Legend of Zelda: Oracle of Ages and Oracle of Seasons.
Comment 1 Lillian Lynn Lemmer 2015-07-24 01:35:42 UTC
Hm, oops, seems like my shar file didn't submit because it was blank... just gimme a little bit to fix that.
Comment 2 Lillian Lynn Lemmer 2015-07-24 01:38:33 UTC
Created attachment 159125 [details]
The shar file for Hypatia 0.2.29
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-24 06:53:54 UTC
Thanks for your submission Lillian!

As per the original work to commit this to the ports tree, the name of the package must match the PyPi name (hypatia_engine).

I can see quite a few issues that need to be addressed, so I highly recommend running your port through QA, which will highlight the issues for you, including:

 * portlint
 * poudriere

You can find more information and instructions here: 

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
Comment 4 Carlos J Puga Medina 2015-07-24 09:23:01 UTC
(In reply to Kubilay Kocak from comment #3)

I take charge of provide logs via poudriere, portlint output, etc.
Comment 5 Carlos J Puga Medina 2015-07-24 19:29:12 UTC
Created attachment 159196 [details]
hypatia.shar
Comment 6 Carlos J Puga Medina 2015-07-24 19:48:04 UTC
% portlint -AC
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 1 warning found.
Comment 8 Carlos J Puga Medina 2015-07-25 21:07:20 UTC
Kubilay,

The distfile is downloaded from a GH repository (no CHEESESHOP site). Rename it to hypatia_engine makes sense.
Comment 9 Carlos J Puga Medina 2015-07-25 21:12:13 UTC
Created attachment 159223 [details]
hypatia.shar
Comment 10 Carlos J Puga Medina 2015-07-25 21:18:50 UTC
Created attachment 159224 [details]
hypatia.shar
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2015-07-26 10:56:19 UTC
On my testbox 10.1-i386 math/atlas fails to build, so I can't test the port.

On 10.1a and 9.3a it builds.
Comment 12 Carlos J Puga Medina 2015-08-03 15:45:04 UTC
(In reply to Kurt Jaeger from comment #11)

OK, anything else? We can commit this port... if koobs@ is agree.

This tarball is different

https://pypi.python.org/packages/source/h/hypatia_engine/hypatia_engine-0.2.29.tar.gz

than the sources from the GH repository.
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2015-08-04 11:17:23 UTC
So, what source for the engine is correct ? github oder pypi ? And which name
is correct for the port ?
Comment 14 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-04 11:34:35 UTC
(In reply to Kurt Jaeger from comment #13)

My last comment on the phabricator review covers it, but just to reiterate:

- correct name is the one that matches pypi name: hypatia_engine
- master_site doesnt really matter. it's available from CHEESESHOP (preferred default) and github
Comment 15 Carlos J Puga Medina 2015-08-04 19:23:47 UTC
Created attachment 159549 [details]
hypatia_engine.shar

- Changed hypatia -> hypatia_engine portname.
Comment 16 Kurt Jaeger freebsd_committer freebsd_triage 2015-08-04 20:37:12 UTC
Testing @work
Comment 17 commit-hook freebsd_committer freebsd_triage 2015-08-06 05:18:59 UTC
A commit references this bug:

Author: pi
Date: Thu Aug  6 05:18:26 UTC 2015
New revision: 393630
URL: https://svnweb.freebsd.org/changeset/ports/393630

Log:
  New port: games/hypatia_engine

  Make 2D action adventure games. For programmers and nonprogrammers alike.
  Create a games like Legend of Zelda: Oracle of Ages and Oracle of Seasons.

  WWW: http://lillian-lemmer.github.io/hypatia

  PR:		201802
  Submitted by:	Lillian Lynn Lemmer <lillian.lynn.lemmer@gmail.com>

Changes:
  head/games/Makefile
  head/games/hypatia_engine/
  head/games/hypatia_engine/Makefile
  head/games/hypatia_engine/distinfo
  head/games/hypatia_engine/pkg-descr
Comment 18 Kurt Jaeger freebsd_committer freebsd_triage 2015-08-06 05:21:09 UTC
build-tests on cur 93a 10.1a 10.1i were OK.

Committed, thanks!