Bug 201958 - [patch] MIPS: Add RT5350F SoC support
Summary: [patch] MIPS: Add RT5350F SoC support
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: mips Any
: --- Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2015-07-29 05:07 UTC by Emmanuel Vadot
Modified: 2018-05-21 00:02 UTC (History)
3 users (show)

See Also:


Attachments
rt5350 support (29.93 KB, patch)
2015-07-29 05:07 UTC, Emmanuel Vadot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emmanuel Vadot 2015-07-29 05:07:57 UTC
Created attachment 159354 [details]
rt5350 support

The RT5350 is a MIPS SoC by RaLink.
The SoC is pretty similar to the already in-tree RT305X.

This patch adds :

 - Support for the RT5350F
 - Selection of SoC in kernel config
 - Add kernel config RT5350_BASE and corresponding hint files with sane defaults.
 - Add kernel config for the Olimex RT5350 EVB and hints files
 - Configuration of GPIO via pinmask/pinon and function_set/fonction_clear hint value.
 - Add a pinin hint value to configure a GPIO as input at boot.
Comment 1 Adrian Chadd freebsd_committer 2015-10-24 16:56:38 UTC
hi!

Cool. I'll look at committing this soon.

Question: why'd you remove GPIO_BIT_SET/GPIO_BIT_CLR? You're directly calling the bus_read/bus_write code now. Is this intentional?

Does this also work with RT305x?
Comment 2 Emmanuel Vadot 2015-10-24 17:01:52 UTC
The macros were removed cause they didn't work and I was too lazy at the time to check what was the problem. And, of course, after I forgot to correct and use them.

I don't have any RT305x hardware to test so I don't know if I broke something or not.
Comment 3 Adrian Chadd freebsd_committer 2015-10-24 17:05:17 UTC
ok, let's go see if I can find some RT305x and RT5350 hardware to test with.
Comment 4 Kevin Lo freebsd_committer 2015-10-26 15:07:19 UTC
(In reply to Emmanuel Vadot from comment #0)

Thanks for working on it.  I have a diff that returns the clock frequency 
from rt305x_clock_freq() instead of a hard coded PLATFORM_COUNTER_FREQ and
supports RAM size detection.

http://people.freebsd.org/~kevlo/rt5350.diff

Could you test it?  Thanks.
Comment 5 Emmanuel Vadot 2015-10-26 18:49:04 UTC
I'll try that next week.
Do you have any RT305x hardware to test if my patch have any regression ?

Thanks.
Comment 6 Kevin Lo freebsd_committer 2015-10-27 03:36:08 UTC
Mine is Hame MPR-A1.  I haven't had time to test your gpio driver yet.
BTW, does rt work?
Comment 7 Emmanuel Vadot 2015-10-27 07:55:16 UTC
If rt == it == gpio, yes the gpios are working.
The only thing not working on the board now are the wifi chipset and the ethernet switch. I need to find some time to work on it.
Comment 8 Kevin Lo freebsd_committer 2015-10-27 09:52:35 UTC
Sorry, I mean the ethernet adapter (sys/dev/rt).
Comment 9 Eitan Adler freebsd_committer freebsd_triage 2018-05-20 23:59:47 UTC
For bugs matching the following conditions:
- Status == In Progress
- Assignee == "bugs@FreeBSD.org"
- Last Modified Year <= 2017

Do
- Set Status to "Open"