Bug 201959 - shells/bash: Missing -Wl,-export-dynamic breaks "enable -f"
Summary: shells/bash: Missing -Wl,-export-dynamic breaks "enable -f"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-29 05:19 UTC by Conrad Meyer
Modified: 2015-07-30 18:53 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Meyer freebsd_committer 2015-07-29 05:19:26 UTC
bash is missing -Wl,-export-dynamic. Without it, bash extensions can't use symbols provided by the program ("enable -f").

Here's a patch:

--- a/shells/bash/Makefile
+++ b/shells/bash/Makefile
@@ -55,6 +55,7 @@ CONFIGURE_ARGS+=      --without-bash-malloc \
                        --enable-disabled-builtins

 CFLAGS+=               -DUSE_MKTEMP=1 -DUSE_MKSTEMP=1
+CFLAGS+=               -Wl,-export-dynamic

 .if empty(PKGNAMESUFFIX)
 CONFLICTS+=            bash-static-[0-9]*
Comment 1 Conrad Meyer freebsd_committer 2015-07-29 05:23:20 UTC
https://reviews.freebsd.org/D3231
Comment 2 commit-hook freebsd_committer 2015-07-30 18:51:15 UTC
A commit references this bug:

Author: cem
Date: Thu Jul 30 18:50:19 UTC 2015
New revision: 393258
URL: https://svnweb.freebsd.org/changeset/ports/393258

Log:
  bash: Export symbols for "enable -f"

  PR:		201959
  Reviewed by:	ehaupt
  Approved by:	markj (mentor)
  Sponsored by:	EMC / Isilon Storage Division
  Differential Revision:	https://reviews.freebsd.org/D3231

Changes:
  head/shells/bash/Makefile