Bug 202070 - 'make index' removes INDEX before building INDEX
Summary: 'make index' removes INDEX before building INDEX
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Port Management Team
Keywords: needs-qa
Depends on:
Reported: 2015-08-04 03:17 UTC by Jashank Jeremy
Modified: 2019-11-25 02:01 UTC (History)
6 users (show)

See Also:
koobs: maintainer-feedback? (portmgr)
koobs: merge-quarterly?

Proposed patch (808 bytes, patch)
2015-08-04 03:17 UTC, Jashank Jeremy
no flags Details | Diff
patch-usr_ports-Makefile (744 bytes, patch)
2019-09-06 14:45 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-usr_ports_Makefile_v2 (775 bytes, patch)
2019-09-06 14:53 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jashank Jeremy 2015-08-04 03:17:06 UTC

    'make index' removes INDEX before building INDEX

Steps to Reproduce:

    1) Run a 'make index'.

    2) Interrupt it.

Actual Results:

    INDEX file gone.

Expected Results: 

    INDEX file should only be replaced at the point where there's a
    new INDEX to replace it; essentially, build INDEX.tmp, then swap
    it in.
Comment 1 Jashank Jeremy 2015-08-04 03:17:49 UTC
Created attachment 159515 [details]
Proposed patch
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-08-04 04:29:28 UTC
Pending creation of phabricator review
Comment 3 Jashank Jeremy 2015-08-04 07:42:41 UTC
Differential Revision: https://reviews.freebsd.org/D3298
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-09-06 13:41:40 UTC
ping! I think it is a good idea.
Comment 5 Walter Schwarzenfeld freebsd_triage 2019-09-06 13:42:14 UTC
Patch should updated, line numbers had changed.
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-09-06 14:45:52 UTC
Created attachment 207239 [details]

Update patch.
Comment 7 Walter Schwarzenfeld freebsd_triage 2019-09-06 14:53:11 UTC
Created attachment 207240 [details]

Forgot remove one line.
Comment 8 Adam Weinberger freebsd_committer 2019-11-24 21:15:00 UTC
What's the status here?

Very frequently, `make fetchindex` retrieves a partial INDEX. Looking at my logs, 18% of my fetchindex runs were aborted due to a truncated INDEX-12.bz2. If this patch will resolve that (will it?), I'm in favor of it.