Bug 202225 - [new port] sysutils/vm-bhyve
Summary: [new port] sysutils/vm-bhyve
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-10 16:04 UTC by churchers
Modified: 2015-10-20 16:06 UTC (History)
1 user (show)

See Also:


Attachments
Shar archive (2.78 KB, text/plain)
2015-08-10 16:04 UTC, churchers
no flags Details
v0.8.11 update (2.82 KB, text/plain)
2015-10-19 21:02 UTC, churchers
no flags Details
v0.8.12 (2.87 KB, text/plain)
2015-10-20 13:41 UTC, churchers
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description churchers 2015-08-10 16:04:34 UTC
Created attachment 159737 [details]
Shar archive

Frontend for bhyve to simplify management of virtual machines and related functions
Comment 1 Renato Botelho freebsd_committer 2015-10-19 18:39:57 UTC
Port doesn't pass on portlint first check, what makes it impossible to test. Please install porttools and run:

# portlint -N

inside port directory, fix all the problems and send a new patch
Comment 2 churchers 2015-10-19 21:02:33 UTC
Created attachment 162219 [details]
v0.8.11 update
Comment 3 churchers 2015-10-19 21:04:05 UTC
Thanks for the response.
I thought I'd run portlint as in the quick porting instructions but maybe not.

I have attached an updated version of the port and have tested with portlint -N
Comment 4 Renato Botelho freebsd_committer 2015-10-20 09:26:41 UTC
Now it's passing portlint, thanks! But I have few other comments.

Makefile:

- Set OPTIONS_DEFINE and OPTIONS_DEFAULT for EXAMPLES
- Replace ${STAGEDIR}${PREFIX}/share/examples/vm-bhyve by ${STAGEDIR}${EXAMPLESDIR}
- Remove the line that compress manpage, it is done automatically
- Drop .gz from manpage install line

rc.d/vm

- Use rclint to check warnings and make necessary adjustments
Comment 5 churchers 2015-10-20 13:41:39 UTC
Created attachment 162244 [details]
v0.8.12

Thanks for the information.

I have added EXAMPLES to OPTIONS_DEFINE. According to the handbook, this should be selected by default already (seemed to be in my test). Hopefully the if statement in do-install is reasonable? There may be a more standardised way of doing that but most of the examples in the handbook relate to ports that use configure; I don't seem to get on with Makefiles very well.

I've also made the changes for the examples path and man page.

rc.d/vm seems to pass rclint now. Wasn't certain of the exact syntax for adding the stop command directly to stop_cmd but it seems to be working.
Comment 6 Renato Botelho freebsd_committer 2015-10-20 14:26:19 UTC
(In reply to churchers from comment #5)

Only one more thing, regarding category. I believe it would fit better in sysutils instead of emulators. There are similar ports there, like sysutils/cbsd or sysutils/ezjail. You don't need to send another shar, I'll change it before commit.

I'll also remove that .if for examples, pkg take care of that automatically.

Thanks!
Comment 7 commit-hook freebsd_committer 2015-10-20 15:34:21 UTC
A commit references this bug:

Author: garga
Date: Tue Oct 20 15:33:32 UTC 2015
New revision: 399862
URL: https://svnweb.freebsd.org/changeset/ports/399862

Log:
  Add sysutils/vm-bhyve:

  A frontend for bhyve which provides the 'vm' command
  Create/start/stop virtual machines easily
  Bridged/NAT networking
  BSD/Linux guest support

  WWW: https://github.com/churchers/vm-bhyve

  PR:		202225
  Submitted by:	churchers@gmail.com

Changes:
  head/sysutils/Makefile
  head/sysutils/vm-bhyve/
  head/sysutils/vm-bhyve/Makefile
  head/sysutils/vm-bhyve/distinfo
  head/sysutils/vm-bhyve/pkg-descr
  head/sysutils/vm-bhyve/pkg-plist
Comment 8 churchers 2015-10-20 15:37:35 UTC
Thanks for all the help!