Bug 202321 - [bhyve,patch] More verbose error reporting in bhyve for backing images
Summary: [bhyve,patch] More verbose error reporting in bhyve for backing images
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-virtualization (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-14 13:01 UTC by Willem Jan Withagen
Modified: 2016-06-07 18:59 UTC (History)
1 user (show)

See Also:
wjw: mfc-stable10?


Attachments
more verbose errors when loading a backing file (1.89 KB, patch)
2015-08-14 13:01 UTC, Willem Jan Withagen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Willem Jan Withagen 2015-08-14 13:01:09 UTC
Created attachment 159856 [details]
more verbose errors when loading a backing file

When starting a bhyve proces with an erroneous backing image, then error report does give the info which device we are talking about, or what file is in error.

The the patch generates a bit more info.
Save a lot of soul searching if one has a lot of devices connected.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-08-15 00:53:37 UTC
Fix assignment.
Comment 2 Peter Grehan freebsd_committer 2015-08-24 20:08:45 UTC
This is a useful change: I'll get it in.
Comment 3 commit-hook freebsd_committer 2016-05-27 11:47:53 UTC
A commit references this bug:

Author: bapt
Date: Fri May 27 11:46:54 UTC 2016
New revision: 300843
URL: https://svnweb.freebsd.org/changeset/base/300843

Log:
  Improve error message when failing to open a backing file

  When bhyve cannot open a backing file, it now says explicitly which file
  could not be opened

  Note that the change has only be maed in block_if.c and not in
  pci_virtio_block.c as the error will always be catched by the first

  PR:		202321 (different patch)
  Reviewed by:	grehan
  MFC after:	3 day
  Sponsored by:	Gandi.net
  Differential Revision:	https://reviews.freebsd.org/D6576

Changes:
  head/usr.sbin/bhyve/block_if.c